-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify the otel-collector example #2238
Comments
Is this issue still need to be improved? I'd like to take it as below:
@rakyll thx. |
Am I correct in my understanding that #2962 was closed and not accepted because of the name logger, and that it's a new example, instead of altering the original otel-collector example? Is moving from microk8s to Docker to host the collector desirable, or is it best to retain the microk8s deployment and just simplify it? |
+1 moving to just Docker and docker compose like the other instrumentation examples (e.g. https://github.com/open-telemetry/opentelemetry-go-contrib/blob/e2cab2e7ca4271c0d6474071a7ce48c0c274e840/instrumentation/github.com/gorilla/mux/otelmux/example/docker-compose.yml) do. |
@MrAlias i would like to work on this if this is still needed(quick check at the examples gives the idea it yet to be completed). If so i would modify the example to remove existing k8s deployment step and replace it with a docker compose based example. |
The otel-collector example is doing too much to be an entry level example. It'd great to keep the scope to just export OTLP to a collector running locally (via Docker) to provide an easy to setup entry point to developers.
The text was updated successfully, but these errors were encountered: