-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add logging example #2962
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is not clear now.
Should I pull this and re-submit again?
Or is there something I can do to clear the CI?
rerun |
I pull origin and
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds an example of how to use the logging exporter for the collector. The linked issue this PR says it addresses is one that looks to refactor the existing collector example, not add another one with a different exporter. I do not see the value in accepting these changes, it does not add a unique example of how to use this project. I would recommend it is closed.
The value of this is PR is to provide an example which keep the scope to just export OTLP to a collector running locally (via Docker). Using this example does not require jaeger, prometheus and any other third-party backends, nor does it require users to use k8s to locally establish a cluster. Using this example, you can clearly see the original trace data provided by open-telemetry, not through any other backend that developers might lose the original view of trace data. You can also use this example to understand the easiest way to generate trace data. I keep the original example instead of refactoring it. Because the user can make enhanced observation of the trace data through other backends after using this example. |
I think naming this example |
@lyl156 is this something you are willing to consider? |
What I can do now is to replace the original with mine, because I don't understand your exact thoughts on this issue. |
It is PR for issue#2238.