Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UpDownCounter is not a gauge #3493

Closed
ai-zelenin opened this issue Nov 28, 2022 · 0 comments · Fixed by #3498
Closed

UpDownCounter is not a gauge #3493

ai-zelenin opened this issue Nov 28, 2022 · 0 comments · Fixed by #3498
Labels
pkg:example Related to an example
Milestone
Metric v0.34.0

Comments

@ai-zelenin
Copy link

ai-zelenin commented Nov 28, 2022 •
edited
Loading

meter.AsyncFloat64().Counter acts like gauge so async approach i cant use(do not have counter)
meter.SyncFloat64() do not have gauge so i can not use sync approach

in this examaple

opentelemetry-go/example/prometheus/main.go

Line 61 in d7b3115

gauge, err := meter.SyncFloat64().UpDownCounter("bar", instrument.WithDescription("a fun little gauge"))

meter.SyncFloat64().UpDownCounter called gauge but
meter.SyncFloat64().UpDownCounter acts like counter

i feel there is some mistake here or too confusing and need some clarification
MrAlias added a commit to MrAlias/opentelemetry-go that referenced this issue Nov 29, 2022
@MrAlias
Rename gauge var name in Prometheus example
a34b8bf 
Fix open-telemetry#3493
@MrAlias MrAlias mentioned this issue Nov 29, 2022
Merged
@MrAlias MrAlias added the pkg:example Related to an example label Nov 29, 2022
MadVikingGod pushed a commit that referenced this issue Nov 30, 2022
@MrAlias
Redefine gauge in Prometheus example to be a Gauge (#3498)
291aaa0 
* Rename gauge var name in Prometheus example

Fix #3493

* Switch to actual gauge
@MrAlias MrAlias added this to the Metric v0.34.0 milestone Dec 6, 2022
@MrAlias MrAlias moved this to Done in Go: Metric SDK (Beta) Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pkg:example Related to an example
Projects
No open projects
Go: Metric SDK (Beta)
Status: Done
Milestone
Metric v0.34.0
Development

Successfully merging a pull request may close this issue.

Redefine gauge in Prometheus example to be a Gauge MrAlias/opentelemetry-go
2 participants
@MrAlias @ai-zelenin