-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the Reader.Collect Signature. #3732
Merged
MadVikingGod
merged 7 commits into
open-telemetry:main
from
MadVikingGod:mvg/update_collect
Feb 21, 2023
Merged
Change the Reader.Collect Signature. #3732
MadVikingGod
merged 7 commits into
open-telemetry:main
from
MadVikingGod:mvg/update_collect
Feb 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This DOES NOT make the SDK reuse memory, but it does enable it to be added.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3732 +/- ##
=====================================
Coverage 81.6% 81.6%
=====================================
Files 166 166
Lines 12432 12445 +13
=====================================
+ Hits 10154 10167 +13
Misses 2063 2063
Partials 215 215
|
MrAlias
reviewed
Feb 15, 2023
MrAlias
approved these changes
Feb 16, 2023
Co-authored-by: Tyler Yahn <[email protected]>
hanyuancheung
approved these changes
Feb 20, 2023
This was referenced Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change only modifies the signature of the Collect method to enable future memory reuse. It is part of the solution to #3047.
This does not include changes to the rest of the pipeline to reduce the review surface area.