Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rolling Update daemonset #165

Closed
wants to merge 8 commits into from
Closed

Add rolling Update daemonset #165

wants to merge 8 commits into from

Conversation

juliocleal14
Copy link

@juliocleal14 juliocleal14 commented Apr 12, 2022 •
edited by dmitryax
Loading

Resolves #166

@juliocleal14 juliocleal14 requested review from a team April 12, 2022 23:00
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 12, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: juliocleal13 / name: Julio C Leal (374a8ff)

@TylerHelmuth
Copy link
Member

TylerHelmuth commented Apr 12, 2022 •
edited
Loading

@juliocleal13 thanks for contributing. Can you open a issue that details what this PR adds/fixes?

@TylerHelmuth
Copy link
Member

@juliocleal13 also run make generate-examples so that all the examples are updated with the new chart version.

@dmitryax
Copy link
Member

@juliocleal13 please update your PR after changes made in #159

The additional configuration now should be moved from agentCollector to the root level.

@dackroyd dackroyd mentioned this pull request Sep 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth left review comments

@dmitryax dmitryax dmitryax left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

daemonset rollingUpdate
3 participants
@juliocleal14 @TylerHelmuth @dmitryax