Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: logsCollection CRI regex #377

Merged
merged 1 commit into from
Sep 21, 2022
Merged

fix: logsCollection CRI regex #377

merged 1 commit into from
Sep 21, 2022

Conversation

povilasv
Copy link
Contributor

Ref #376

@povilasv povilasv requested a review from a team September 20, 2022 07:02
TylerHelmuth
TylerHelmuth reviewed Sep 20, 2022
View reviewed changes
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Please run make generate-examples

@povilasv
Copy link
Contributor Author

@TylerHelmuth thanks for review. pushed the change :)

@TylerHelmuth
Copy link
Member

@povilasv looks like something went wrong with your push.

@povilasv
Copy link
Contributor Author

@TylerHelmuth bumped the version again and pushed, and added everything. Hopefully now this works?

Btw make generate-examples throws me "find: ‘charts/opentelemetry-demo/examples’: No such file or directory" error at the end :/

make generate-examples

...
WARNING: Kubernetes configuration file is group-readable. This is insecure. Location: /home/povilasv/.kube/config
WARNING: Kubernetes configuration file is world-readable. This is insecure. Location: /home/povilasv/.kube/config
wrote charts/opentelemetry-collector/examples/daemonset-only/rendered/opentelemetry-collector/templates/serviceaccount.yaml
wrote charts/opentelemetry-collector/examples/daemonset-only/rendered/opentelemetry-collector/templates/configmap-agent.yaml
wrote charts/opentelemetry-collector/examples/daemonset-only/rendered/opentelemetry-collector/templates/daemonset.yaml

find: warning: you have specified the global option -maxdepth after the argument -type, but global options are not positional, i.e., -maxdepth affects tests specified before it as well as those specified after it.  Please specify global options before other arguments.
find: warning: you have specified the global option -mindepth after the argument -type, but global options are not positional, i.e., -mindepth affects tests specified before it as well as those specified after it.  Please specify global options before other arguments.
find: ‘charts/opentelemetry-operator/examples’: No such file or directory
find: warning: you have specified the global option -maxdepth after the argument -type, but global options are not positional, i.e., -maxdepth affects tests specified before it as well as those specified after it.  Please specify global options before other arguments.
find: warning: you have specified the global option -mindepth after the argument -type, but global options are not positional, i.e., -mindepth affects tests specified before it as well as those specified after it.  Please specify global options before other arguments.
find: ‘charts/opentelemetry-demo/examples’: No such file or directory

@TylerHelmuth
Copy link
Member

@povilasv yes that message is expected. Operator and Demo charts don't have examples yet, but we plan to add them.

@TylerHelmuth TylerHelmuth merged commit d77de49 into open-telemetry:main Sep 21, 2022
@povilasv povilasv deleted the fix-k8s-cri-logs branch September 22, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@povilasv @TylerHelmuth