-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ktor: make spanNameExtractor
configurable
#12842
Labels
contribution welcome
Request makes sense, maintainers probably won't have time, contribution would be welcome
Comments
SIMULATAN
added a commit
to SnotyMe/snoty-backend
that referenced
this issue
Dec 7, 2024
It now has support for Ktor 3.0. A workaround is included for the HTTP client span naming. Closes #65 The added `KtorClientTracing` stuff will be obsolete once open-telemetry/opentelemetry-java-instrumentation#12842 is implemented
we would definitely accept a hook similar to what OkHttpTelemetryBuilder already has: Lines 97 to 106 in c2c5d80
|
trask
added
the
contribution welcome
Request makes sense, maintainers probably won't have time, contribution would be welcome
label
Dec 7, 2024
SIMULATAN
added a commit
to SIMULATAN/opentelemetry-java-instrumentation
that referenced
this issue
Dec 8, 2024
SIMULATAN
changed the title
Ktor 3.0: (client) make
Ktor: make Dec 8, 2024
spanNameExtractor
configurablespanNameExtractor
configurable
trask
pushed a commit
that referenced
this issue
Dec 12, 2024
Resolved with #12850 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
contribution welcome
Request makes sense, maintainers probably won't have time, contribution would be welcome
Whilst the semconv doesn't explicitly require the URL to be part of the span name, I would like to see more information than just the request method there.
Thus, I propose to add a simple
setSpanNameExtractor
method to theAbstractKtorClientTracingBuilder
, similar to what #8255 did. Something like this would do just fine:#9607 already brought this topic up, but the semconv has changed since then to include the
url.template
if enabled. In my opinion, my proposal would allow users to implement this, should they choose to, whilst preserving the original, non-experimental default.The text was updated successfully, but these errors were encountered: