-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add getters/accessors for readable fields in ReadWriteLogRecord. #6924
Merged
jack-berg
merged 11 commits into
open-telemetry:main
from
breedx-splk:add_getters_to_WRLR
Dec 19, 2024
+127
−8
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
85b3a60
Add getters/accessors for readable fields in ReadWriteLogRecord.
breedx-splk 23c1c1b
allow nonbreaking interface extension
breedx-splk 84e8910
eliminate conversion in test
breedx-splk daefe10
remove easy way to pick up getters, now with even more duplication!
breedx-splk f251094
remove getResource() because it doesn't exist on ReadableSpan.
breedx-splk 2c68421
spotless
breedx-splk 1440a2e
remove getResource()
breedx-splk d3b5acb
remove direct usage of deprecated body
breedx-splk 26039f4
deprecation
breedx-splk 6a458a2
remove methods
breedx-splk a934242
remove local change that snuck in sorry whoops
breedx-splk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,16 @@ | ||
Comparing source compatibility of opentelemetry-sdk-logs-1.46.0-SNAPSHOT.jar against opentelemetry-sdk-logs-1.45.0.jar | ||
No changes. | ||
*** MODIFIED INTERFACE: PUBLIC ABSTRACT io.opentelemetry.sdk.logs.ReadWriteLogRecord (not serializable) | ||
=== CLASS FILE FORMAT VERSION: 52.0 <- 52.0 | ||
+++ NEW METHOD: PUBLIC(+) java.lang.Object getAttribute(io.opentelemetry.api.common.AttributeKey<T>) | ||
+++ NEW ANNOTATION: javax.annotation.Nullable | ||
GENERIC TEMPLATES: +++ T:java.lang.Object | ||
+++ NEW METHOD: PUBLIC(+) io.opentelemetry.api.common.Attributes getAttributes() | ||
+++ NEW METHOD: PUBLIC(+) io.opentelemetry.api.common.Value<?> getBodyValue() | ||
+++ NEW ANNOTATION: javax.annotation.Nullable | ||
+++ NEW METHOD: PUBLIC(+) io.opentelemetry.sdk.common.InstrumentationScopeInfo getInstrumentationScopeInfo() | ||
+++ NEW METHOD: PUBLIC(+) long getObservedTimestampEpochNanos() | ||
+++ NEW METHOD: PUBLIC(+) io.opentelemetry.api.logs.Severity getSeverity() | ||
+++ NEW METHOD: PUBLIC(+) java.lang.String getSeverityText() | ||
+++ NEW ANNOTATION: javax.annotation.Nullable | ||
+++ NEW METHOD: PUBLIC(+) io.opentelemetry.api.trace.SpanContext getSpanContext() | ||
+++ NEW METHOD: PUBLIC(+) long getTimestampEpochNanos() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it would be worth adding some unit tests for these default methods? It could be beneficial for possible future classes that do not overwrite them (or overwrite them partially)