Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release main #1213

Merged
merged 1 commit into from
Sep 28, 2022
Merged

chore: release main #1213

merged 1 commit into from
Sep 28, 2022

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Sep 28, 2022

🤖 I have created a release beep boop

@opentelemetry/auto-instrumentations-node: 0.33.1

Dependencies

  • The following workspace dependencies were updated
    • dependencies
      • @opentelemetry/instrumentation-express bumped from ^0.31.1 to ^0.31.2
instrumentation-express: 0.31.2

0.31.2 (2022-09-28)

Bug Fixes

  • express: use the same clock for span start and end (#1210) (cbeef6e)

This PR was generated with Release Please. See documentation.

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #1213 (b3658d5) into main (cbeef6e) will increase coverage by 0.56%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1213      +/-   ##
==========================================
+ Coverage   96.08%   96.64%   +0.56%     
==========================================
  Files          14       20       +6     
  Lines         893     1132     +239     
  Branches      191      245      +54     
==========================================
+ Hits          858     1094     +236     
- Misses         35       38       +3     
Impacted Files Coverage Δ
...try-instrumentation-express/src/instrumentation.ts 99.28% <0.00%> (ø)
...trumentation-express/src/enums/ExpressLayerType.ts 100.00% <0.00%> (ø)
...tapackages/auto-instrumentations-node/src/utils.ts 98.07% <0.00%> (ø)
...opentelemetry-instrumentation-express/src/types.ts 100.00% <0.00%> (ø)
...opentelemetry-instrumentation-express/src/utils.ts 97.36% <0.00%> (ø)
...nstrumentation-express/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)

@dyladan
Copy link
Member Author

dyladan commented Sep 28, 2022

@open-telemetry/javascript-approvers this is a high priority fix for express so we should get this reviewed ASAP

@rauno56
Copy link
Member

rauno56 commented Sep 28, 2022

I think the meaningful review is already done while merging the feature.

@rauno56 rauno56 merged commit 3522660 into main Sep 28, 2022
@rauno56 rauno56 deleted the release-please--branches--main branch September 28, 2022 20:09
@dyladan
Copy link
Member Author

dyladan commented Sep 28, 2022

@dyladan
Copy link
Member Author

dyladan commented Sep 28, 2022

@Flarna
Copy link
Member

Flarna commented Sep 28, 2022

@dyladan Seems that publish to NPM was again not executed similar as in the last releaes

@DAlperin
Copy link

@dyladan, to @Flarna's point, it seems like the release please github action skipped the publish to npm step https://github.com/open-telemetry/opentelemetry-js-contrib/actions/runs/3146553848/jobs/5115129297

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants