refactor(net): remove hardcoded values, use semantic conventions #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #414 +/- ##
=======================================
Coverage 94.21% 94.21%
=======================================
Files 12 12
Lines 432 432
Branches 48 48
=======================================
Hits 407 407
Misses 25 25 |
Flarna
approved these changes
Apr 7, 2021
dyladan
reviewed
Apr 7, 2021
dyladan
approved these changes
Apr 7, 2021
obecny
approved these changes
Apr 8, 2021
obecny
pushed a commit
to obecny/opentelemetry-js-contrib
that referenced
this pull request
Apr 15, 2021
…n-telemetry#414) * refactor: remove hardcoded values, use semantic conventions * fix: revert deps version change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of the changes
Use semantic-conventions package to bring in
PIPEandUNIXattributes.