Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: unify formatting in ISSUE_TEMPLATE's #426

Merged
merged 4 commits into from
Apr 16, 2021

Conversation

rauno56
Copy link
Member

@rauno56 rauno56 commented Apr 15, 2021

Saw something that should've been commented out, but wasn't while making an issue, went through all other templates as well.
I know a lot is in being changed because of coming GA, so if it harms more than does good(perhaps those or conflicting changes are already in a branch somewhere), just close and forget it.

Which problem is this PR solving?

It unifies formatting across ISSUE_TEMPLATE files.

Short description of the changes

  • Comment out everything, that's describing how to put together the issue and should not land in the final presented text,
  • Consistent whitespace
  • Change bold to H3 everywhere, bug_report.md had one, feature and plugin requests had bold.

@rauno56 rauno56 requested a review from a team April 15, 2021 15:39
@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #426 (f152c8e) into main (1e2a165) will not change coverage.
The diff coverage is n/a.

❗ Current head f152c8e differs from pull request most recent head 6312ebb. Consider uploading reports for the commit 6312ebb to get more accurate results

@@           Coverage Diff           @@
##             main     #426   +/-   ##
=======================================
  Coverage   95.83%   95.83%           
=======================================
  Files          15       15           
  Lines         624      624           
  Branches       94       94           
=======================================
  Hits          598      598           
  Misses         26       26           

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just some tiny interpunction

.github/ISSUE_TEMPLATE/plugin_request.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/plugin_request.md Outdated Show resolved Hide resolved
@vmarchaud vmarchaud merged commit 0238980 into open-telemetry:main Apr 16, 2021
@rauno56 rauno56 deleted the chore/issue-template branch April 20, 2021 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants