Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jaeger exporter] Add env var for agent host #536

Closed
naseemkullah opened this issue Nov 14, 2019 · 6 comments
Closed

[jaeger exporter] Add env var for agent host #536

naseemkullah opened this issue Nov 14, 2019 · 6 comments

Comments

@naseemkullah
Copy link
Member

naseemkullah commented Nov 14, 2019

Is your feature request related to a problem? Please describe.
To point to an agent daemonset pod running on local node, the value has to be set in the kubernetes spec as v1:status.hostIP (this cannot be set in code, not easily at least) , it would be very convenient to simply add a JAEGER_AGENT_HOST env var that the exporter looks for without it being explicitly set in the exporter config, and if it is not set, default to localhost of course. please see `open-telemetry/opentelemetry-specification#172 (comment)

Describe the solution you'd like
JAEGER_AGENT_HOST or JAEGER_HOST whose value will be used as the host in the exporter config, if set.

Describe alternatives you've considered
adding process.env.JAEGER_AGENT_HOST in all projects that use open telemetry with jaeger exporter.

Additional context

status.hostIP - the node’s IP, available since v1.7.0-alpha.1

https://kubernetes.io/docs/tasks/inject-data-application/downward-api-volume-expose-pod-information/#capabilities-of-the-downward-api

@mayurkale22
Copy link
Member

Should we wait for specs issues to get approved/merged?

@dyladan
Copy link
Member

dyladan commented Nov 19, 2019

This is really an SDK mechanism, but at the same time I think this should be decided on for all SIGs, not just ours. I'm not sure where questions that are not spec related but affect all SIGs should go. Probably still in spec.

@dyladan
Copy link
Member

dyladan commented Nov 25, 2019

@mayurkale22 maybe we should consider some sort of waiting-on-specs label for issues like this?

@dyladan
Copy link
Member

dyladan commented Nov 25, 2019

Or we could close it and re-open when the spec is ready.

@mayurkale22
Copy link
Member

@mayurkale22 maybe we should consider some sort of waiting-on-specs label for issues like this?

I like this idea, created a label "waiting-for-spec".

@naseemkullah
Copy link
Member Author

naseemkullah commented Apr 17, 2020

This can be closed as we went ahead with JAEGER_AGENT_HOST via #924

pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
martinkuba pushed a commit to martinkuba/opentelemetry-js that referenced this issue Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants