-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jaeger exporter] Add env var for agent host #536
Comments
Should we wait for specs issues to get approved/merged? |
This is really an SDK mechanism, but at the same time I think this should be decided on for all SIGs, not just ours. I'm not sure where questions that are not spec related but affect all SIGs should go. Probably still in spec. |
@mayurkale22 maybe we should consider some sort of |
Or we could close it and re-open when the spec is ready. |
I like this idea, created a label "waiting-for-spec". |
This can be closed as we went ahead with |
Co-authored-by: vmarchaud <[email protected]> Co-authored-by: vmarchaud <[email protected]>
Co-authored-by: vmarchaud <[email protected]> Co-authored-by: vmarchaud <[email protected]>
Is your feature request related to a problem? Please describe.
To point to an agent daemonset pod running on local node, the value has to be set in the kubernetes spec as
v1:status.hostIP
(this cannot be set in code, not easily at least) , it would be very convenient to simply add aJAEGER_AGENT_HOST
env var that the exporter looks for without it being explicitly set in the exporter config, and if it is not set, default to localhost of course. please see `open-telemetry/opentelemetry-specification#172 (comment)Describe the solution you'd like
JAEGER_AGENT_HOST
orJAEGER_HOST
whose value will be used as thehost
in the exporter config, if set.Describe alternatives you've considered
adding
process.env.JAEGER_AGENT_HOST
in all projects that use open telemetry with jaeger exporter.Additional context
https://kubernetes.io/docs/tasks/inject-data-application/downward-api-volume-expose-pod-information/#capabilities-of-the-downward-api
The text was updated successfully, but these errors were encountered: