Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http/https plugins are not compatible to @types/node 12.12.8 #541

Closed
Flarna opened this issue Nov 15, 2019 · 0 comments · Fixed by #548
Closed

http/https plugins are not compatible to @types/node 12.12.8 #541

Flarna opened this issue Nov 15, 2019 · 0 comments · Fixed by #548
Assignees
Labels
bug Something isn't working

Comments

@Flarna
Copy link
Member

Flarna commented Nov 15, 2019

What version of OpenTelemetry are you using?

Latest master

What version of Node are you using?

12.13.0

What did you do?

Compile the code in opentelemetry-js repo

What did you expect to see?

No compile errors.

What did you see instead?

compile errors, see e.g. https://circleci.com/gh/open-telemetry/opentelemetry-js/8436?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

src/http.ts:343:15 - error TS2345: Argument of type 'UrlWithStringQuery | null' is not assignable to parameter of type 'RequestOptions | (RequestOptions & Partial<UrlWithParsedQuery>) | null'.
  Type 'UrlWithStringQuery' is not assignable to type 'RequestOptions | (RequestOptions & Partial<UrlWithParsedQuery>) | null'.
    Type 'UrlWithStringQuery' is not assignable to type 'RequestOptions & Partial<UrlWithParsedQuery>'.
      Type 'UrlWithStringQuery' is not assignable to type 'RequestOptions'.
        Types of property 'protocol' are incompatible.
          Type 'string | null' is not assignable to type 'string | undefined'.
            Type 'null' is not assignable to type 'string | undefined'.

Additional context

@types/node version 12.12.8 had changes in url typings. see DefinitelyTyped/DefinitelyTyped#40118

Most issues are addressed by DefinitelyTyped/DefinitelyTyped#40430

@Flarna Flarna added the bug Something isn't working label Nov 15, 2019
@Flarna Flarna changed the title http plugin is not compatible to @types/node 12.12.8 http/https plugins are not compatible to @types/node 12.12.8 Nov 15, 2019
@OlivierAlbertini OlivierAlbertini self-assigned this Nov 16, 2019
OlivierAlbertini added a commit to VilledeMontreal/opentelemetry-js that referenced this issue Nov 16, 2019
closes open-telemetry#541

Signed-off-by: Olivier Albertini <[email protected]>
OlivierAlbertini added a commit to VilledeMontreal/opentelemetry-js that referenced this issue Nov 16, 2019
closes open-telemetry#541

Signed-off-by: Olivier Albertini <[email protected]>
OlivierAlbertini added a commit to VilledeMontreal/opentelemetry-js that referenced this issue Nov 16, 2019
closes open-telemetry#541

Signed-off-by: Olivier Albertini <[email protected]>
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
martinkuba pushed a commit to martinkuba/opentelemetry-js that referenced this issue Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants