Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin] Add span.kind property to attribute #594

Closed
OlivierAlbertini opened this issue Dec 5, 2019 · 5 comments · Fixed by #596
Closed

[plugin] Add span.kind property to attribute #594

OlivierAlbertini opened this issue Dec 5, 2019 · 5 comments · Fixed by #596
Labels
Discussion Issue or PR that needs/is extended discussion. enhancement New feature or request

Comments

@OlivierAlbertini
Copy link
Member

Here an example of span:

Capture d’écran, le 2019-12-05 à 15 20 04

It would be nice to have a kind attribute for identifying if it's "server" or "client". It could be added in the zipkin/jaeger plugins. WDYT ?

@OlivierAlbertini OlivierAlbertini added the Discussion Issue or PR that needs/is extended discussion. label Dec 5, 2019
@OlivierAlbertini OlivierAlbertini changed the title [plugin] add span.kind property to attribute [plugin] Add span.kind property to attribute Dec 5, 2019
@mayurkale22
Copy link
Member

AFAIK we already set this property in each plugins and it is being properly exported in Zipkin backend (becoz it supports kind attribute). Jaeger exporter doesn;t have an equivalent mapping for kind, I was thinking to translate it into Jaeger tags similar to status.code and status.name. WDYT?

@mayurkale22
Copy link
Member

Just checked OpenCensus' Java implementation, we have converted span.kind to Jaeger Tag. Let me know what do you think, I can open a PR to fix that.

@OlivierAlbertini
Copy link
Member Author

Just checked OpenCensus' Java implementation, we have converted span.kind to Jaeger Tag. Let me know what do you think, I can open a PR to fix that.

I think that Jaeger Tag is good.

@dyladan
Copy link
Member

dyladan commented Dec 6, 2019

Does this seem like something that should be brought up in spec? In multi-language environments it might be confusing if only some languages set the span.kind tag

@OlivierAlbertini OlivierAlbertini added the enhancement New feature or request label Dec 6, 2019
@OlivierAlbertini
Copy link
Member Author

Does this seem like something that should be brought up in spec? In multi-language environments it might be confusing if only some languages set the span.kind tag

I think that it depend on the backend more than the language. It's already exported in Zipkin, it's matter to be consistent. WDYT ?

it is being properly exported in Zipkin backend (becoz it supports kind attribute). Jaeger exporter doesn;t have an equivalent mapping for kind,

pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
martinkuba pushed a commit to martinkuba/opentelemetry-js that referenced this issue Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Issue or PR that needs/is extended discussion. enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants