feat: add more db semantic conventions #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naseemkullah
requested review from
dyladan,
legendecas,
markwolff,
mayurkale22,
mwear,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
naseemkullah
force-pushed
the
more-db-semantic-conventions
branch
from
997fcf1 to
7f8a468
Compare
Codecov Report
@@ Coverage Diff @@
## master #1283 +/- ##
=======================================
Coverage 93.24% 93.24%
=======================================
Files 137 137
Lines 3878 3878
Branches 790 790
=======================================
Hits 3616 3616
Misses 262 262
|
dyladan
reviewed
Jul 7, 2020
packages/opentelemetry-semantic-conventions/src/trace/database.ts
Outdated
Show resolved
Hide resolved
naseemkullah
commented
Jul 7, 2020
packages/opentelemetry-semantic-conventions/src/trace/database.ts
Outdated
Show resolved
Hide resolved
mayurkale22
approved these changes
Jul 7, 2020
naseemkullah
changed the title
lykkin
approved these changes
Jul 8, 2020
dyladan
approved these changes
Jul 8, 2020
markwolff
approved these changes
Jul 8, 2020
Also adds tsdocs for attributes, copy pasting from spec. Signed-off-by: Naseem <[email protected]>
naseemkullah
force-pushed
the
more-db-semantic-conventions
branch
from
ab5ac2b to
f1360db
Compare
mayurkale22
approved these changes
Jul 10, 2020
vmarchaud
approved these changes
Jul 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of the changes
db.systemin particular.