-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate exporter-collector-grpc to grpc-js #2092
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2092 +/- ##
=======================================
Coverage 92.73% 92.73%
=======================================
Files 137 137
Lines 4915 4915
Branches 1015 1015
=======================================
Hits 4558 4558
Misses 357 357 |
cc @dyladan since you have internal stats of dynatrace for this but i would say thats fine too since there are non-grpc exporter available (but we need to update the package.json engines field) |
cc @dradetsky |
I think it's fine as long as 8.5 customers have the ability to use the http exporter or something else and are not entirely locked out. At some point we should consider dropping 8.x entirely |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's really that easy?
Which problem is this PR solving?
Short description of the changes
exporter-collector-grpc
grpc-js is compatible with
I would say it should be fine, but I would like to know what other thinks ?