-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: start a style guide #2683
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2683 +/- ##
=======================================
Coverage 92.52% 92.52%
=======================================
Files 144 144
Lines 5177 5177
Branches 1102 1102
=======================================
Hits 4790 4790
Misses 387 387 |
Co-authored-by: legendecas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i believe we should advise against using null
and prefer using undefined
(even though we treat them as the same) too
|
This should be considered a living document. Please make suggestions for additional rules if you feel there is something important that has been missed.