-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(plugin-pg-pool): fix codecov path #657
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyladan
approved these changes
Jan 2, 2020
Codecov Report
@@ Coverage Diff @@
## master #657 +/- ##
==========================================
- Coverage 91.46% 89.62% -1.85%
==========================================
Files 214 214
Lines 10043 10039 -4
Branches 913 931 +18
==========================================
- Hits 9186 8997 -189
- Misses 857 1042 +185
|
markwolff
approved these changes
Jan 3, 2020
vmarchaud
approved these changes
Jan 3, 2020
xiao-lix
approved these changes
Jan 3, 2020
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
Co-authored-by: dyladan <[email protected]>
martinkuba
pushed a commit
to martinkuba/opentelemetry-js
that referenced
this pull request
Mar 13, 2024
Co-authored-by: dyladan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Currently, pg-pool plugin codecov report floating outside
packages/
folder, see below image. Ideally, it should stay inside apackages/
folder similar to other modules./cc @xiao-lix