Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add test to ensure plugins support latest module versions #670

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Jan 6, 2020

@codecov-io
Copy link

codecov-io commented Jan 6, 2020

Codecov Report

Merging #670 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #670      +/-   ##
==========================================
- Coverage   91.47%   91.41%   -0.06%     
==========================================
  Files         216      215       -1     
  Lines       10048    10010      -38     
  Branches      913      910       -3     
==========================================
- Hits         9191     9151      -40     
- Misses        857      859       +2
Impacted Files Coverage Δ
...kages/opentelemetry-plugin-dns/test/utils/utils.ts 33.33% <0%> (-26.67%) ⬇️
...es/opentelemetry-node/src/instrumentation/utils.ts 90.47% <0%> (-9.53%) ⬇️
packages/opentelemetry-plugin-mysql/src/utils.ts 90.9% <0%> (-4.55%) ⬇️
...ges/opentelemetry-exporter-zipkin/src/transform.ts 100% <0%> (ø) ⬆️
...telemetry-plugin-grpc/test/utils/assertionUtils.ts 100% <0%> (ø) ⬆️
.../opentelemetry-plugin-dns/test/utils/assertSpan.ts 100% <0%> (ø) ⬆️
...-metrics/test/export/ConsoleMetricExporter.test.ts 100% <0%> (ø) ⬆️
.../opentelemetry-exporter-zipkin/test/zipkin.test.ts 100% <0%> (ø) ⬆️
...pe-async-hooks/test/AsyncHooksScopeManager.test.ts 100% <0%> (ø) ⬆️
...try-plugin-dns/test/functionals/dns-enable.test.ts 100% <0%> (ø) ⬆️
... and 7 more

@mayurkale22 mayurkale22 added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. enhancement New feature or request Awaiting reviewer feedback labels Jan 6, 2020
Copy link
Member

@vmarchaud vmarchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but is there a way to get alerted on that ? Something directly on gitter or an issue on github would be easier no ?

Copy link
Member

@OlivierAlbertini OlivierAlbertini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@obecny
Copy link
Member

obecny commented Jul 27, 2020

@dyladan our circle ci config has changed since then, is this yet needed ?

@dyladan
Copy link
Member Author

dyladan commented Jul 27, 2020

Think something is still needed, but the ci infra is completely changed and there was no way to report results. Will close this until we can come up with a better solution

@dyladan dyladan closed this Jul 27, 2020
@Flarna Flarna deleted the supported-versions-check branch August 12, 2020 23:09
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a test to ensure plugins are targeting latest versions
6 participants