Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Resource[Spans|Metrics] to the main proto files #95

Closed
bogdandrutu opened this issue Jan 14, 2020 · 0 comments · Fixed by #96
Closed

Move Resource[Spans|Metrics] to the main proto files #95

bogdandrutu opened this issue Jan 14, 2020 · 0 comments · Fixed by #96

Comments

@bogdandrutu
Copy link
Member

Currently this messages are defined in the collector directory but they should probably live directly in the [metrics|trace].proto files because they define the structure of the data produce by the library.

Same comment applies to the Library[Spans|Metrics] if #94 gets merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move Resource[Span|Metrics] out of collector bogdandrutu/opentelemetry-proto
1 participant
@bogdandrutu