Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Resource[Span|Metrics] out of collector #96

Merged
merged 2 commits into from
Jan 31, 2020

Conversation

bogdandrutu
Copy link
Member

Fixes #95

Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a code move. LGTM

Signed-off-by: Bogdan Cristian Drutu <[email protected]>
Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@bogdandrutu bogdandrutu merged commit 06e6c1e into open-telemetry:master Jan 31, 2020
@bogdandrutu bogdandrutu deleted the moveres branch January 31, 2020 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Resource[Spans|Metrics] to the main proto files
3 participants