[proemtheus-remote-write] fix label sorting #2078
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tals
force-pushed
the
main
branch
4 times, most recently
from
32305a4 to
91634ca
Compare
This is required by the spec, and it is actively enforced by Thanos. Without this, users hit a "409 Conflict" error
|
+1 thanks for making this PR @tals This is certainly a needed feature because Thanos chose to define and assert the missing remote-write spec - see here, one of the assertions being lexicographically sorted label names cc'ing @lzchen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is required by the spec
"MUST have label names sorted in lexicographical order."
This library would inject the
__name__label at the end. This broke the label ordering, leading Thanos to reject the write with a "409 Conflict" error.Type of change
Please delete options that are not relevant.
Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
Unit test, and tested against a Thanos instance.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.