Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pymssql: fix entry_point for auto-instrumentation #3214

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

emdneto
Copy link
Member

@emdneto emdneto commented Jan 28, 2025

Description

I was testing the new instrumentation:

opentelemetry-instrument --traces_exporter console --metrics_exporter none --logs_exporter none python -c 'import pymssql'

And got:
AttributeError: module 'opentelemetry.instrumentation.pymssql' has no attribute 'pymssqlInstrumentor'. Did you mean: 'PyMSSQLInstrumentor'?

The added test fails on main.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tox

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@emdneto emdneto added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 28, 2025
@xrmx xrmx enabled auto-merge (squash) January 28, 2025 13:58
@xrmx xrmx merged commit dd68241 into open-telemetry:main Jan 28, 2025
694 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants