Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added aiohttp-server instrumentation injection to module web_app #3218

Closed
wants to merge 1 commit into from

Conversation

nesb1
Copy link
Contributor

@nesb1 nesb1 commented Jan 29, 2025

Description

Added aiohttp-serverinstrumentation  injection to module web_app because Application declared in web_app module, web only reimports this.
If we leave the injection only in module web_app, then the tests will fail, we need inject both.

Application definition
Application reimport

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Unit tests works

Does This PR Require a Core Repo Change?

  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@nesb1 nesb1 requested a review from a team as a code owner January 29, 2025 11:33
@nesb1 nesb1 force-pushed the main branch 3 times, most recently from a543bfb to 7ad37f8 Compare January 29, 2025 12:03
@nesb1 nesb1 changed the title Changed aiohttp-server instrumentation injecting module from web to web_app Added aiohttp-server instrumentation injection to module web_app Jan 29, 2025
…cause Application declared in `web_app` module, web only reimports this.

If we leave the injection only in module `web_app`, then the tests will fail, we need inject both.
@nesb1
Copy link
Contributor Author

nesb1 commented Jan 30, 2025

Closed because problem is bigger than just import from web_app
#3221

@nesb1 nesb1 closed this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant