Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add opentelemetry proto files #785

Closed
ocelotl opened this issue Jun 7, 2020 · 2 comments · Fixed by #728
Closed

Add opentelemetry proto files #785

ocelotl opened this issue Jun 7, 2020 · 2 comments · Fixed by #728
Assignees
@ocelotl

Comments

@ocelotl
Copy link
Contributor

ocelotl commented Jun 7, 2020

Add OpenTelemetry proto generated Python files.
@ocelotl ocelotl self-assigned this Jun 7, 2020
@ocelotl ocelotl mentioned this issue Jun 7, 2020
Merged
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Jun 7, 2020
@ocelotl
Add proto files
6a170f9 
Fixes open-telemetry#785
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Jun 8, 2020
@ocelotl
Add proto files
a1129ab 
Fixes open-telemetry#785
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Jun 8, 2020
@ocelotl
Add proto files
5370937 
Fixes open-telemetry#785
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Jun 8, 2020
@ocelotl
Add proto files
71c2b30 
Fixes open-telemetry#785
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Jun 9, 2020
@ocelotl
Add proto files
3f6e5ab 
Fixes open-telemetry#785
@aabmass
Copy link
Member

aabmass commented Jun 9, 2020

I was wondering if it's worth including a script to regenerate the proto files, too. I imagine it's simple enough but involves a few steps like cloning the proto repo and a bunch of different flags.

I also wanted to pitch generating stubs with something like mypy-protobuf. protoc generates kinda weird code that doesn't work great with tooling or typing. Any thoughts?

@toumorokoshi
Copy link
Member

@aabmass I think those are really good suggestions. I merged in #728 because the OLTP is blocking on this, but if you want to file issues / PRs with those ideas, that would be great.

I'll get around to issues too, later today if you don't have time.

This was referenced Jun 9, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ocelotl ocelotl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add proto files ocelotl/opentelemetry-python
3 participants
@toumorokoshi @aabmass @ocelotl