Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datadog: honor DD environment variables #824

Closed
toumorokoshi opened this issue Jun 12, 2020 · 2 comments · Fixed by #836
Closed

datadog: honor DD environment variables #824

toumorokoshi opened this issue Jun 12, 2020 · 2 comments · Fixed by #836
Assignees
Labels
instrumentation Related to the instrumentation of third party libraries or frameworks

Comments

@toumorokoshi
Copy link
Member

There's a few environment variables that are not honored by the exporter currently. These are:

  • DD_AGENT_HOST, for the agent hostname
  • DATADOG_SERVICE_NAME, DD_SERVICE_NAME, DD_SERVICE for the datadog service name.

There is a more comprehensive list, as outlined here:

https://docs.datadoghq.com/tracing/setup/python/#configuration

@toumorokoshi
Copy link
Member Author

@codeboten codeboten added the instrumentation Related to the instrumentation of third party libraries or frameworks label Jun 16, 2020
@majorgreys majorgreys self-assigned this Jun 16, 2020
@majorgreys
Copy link
Contributor

Thanks for raising these issues @toumorokoshi.

I only added support for configuring DD_TRACE_AGENT_URL whereas setting the agent hostname and port have been deprecated (though the documentation you linked to does not reflect that, which we will address):

https://github.com/open-telemetry/opentelemetry-python/blob/master/ext/opentelemetry-ext-datadog/src/opentelemetry/ext/datadog/exporter.py#L63-L67
http://pypi.datadoghq.com/trace/docs/configuration.html

Similarly, the exporter supports DD_SERVICE whereas the DATADOG_SERVICE_NAME and DD_SERVICE_NAME have been deprecated.

I'll start a PR for adding DD_ENV, as well as the other tracer configuration options missing (DD_VERSION for adding the application version to the root span and DD_TAGS for adding default tags to all spans).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
instrumentation Related to the instrumentation of third party libraries or frameworks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants