chore: improves logs for warning #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcchavezs
requested review from
a team,
aabmass and
lzchen
and removed request for
a team
owais
approved these changes
May 4, 2021
codeboten
reviewed
May 4, 2021
There was a problem hiding this comment.
Thanks for the improvement @jcchavezs! Please add an entry to the changelog as well to let users know of the change.
codeboten
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The log message per se does not provide much actionable information as it does not mention the key for whose attribute we had a decoding issue. This PR includes the key in the warning.
Type of change
Please delete options that are not relevant.