Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shellcheck CI step #3811

Merged
merged 4 commits into from
Apr 9, 2024
Merged

Add shellcheck CI step #3811

merged 4 commits into from
Apr 9, 2024

Conversation

johnbley
Copy link
Member

Description

Per #3789, add a CI step to run shellcheck --severity=warning on all .sh files, similar to open-telemetry/opentelemetry-lambda#396.

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No. But I'm happy to provide the same/similar PR for the Contrib repo as well.

@johnbley johnbley requested a review from a team March 25, 2024 13:21
@srikanthccv srikanthccv added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 26, 2024
@lzchen lzchen merged commit 0a84d7a into open-telemetry:main Apr 9, 2024
233 checks passed
@johnbley johnbley deleted the shellcheck_ci_step branch April 9, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@ocelotl ocelotl ocelotl approved these changes

@xrmx xrmx xrmx approved these changes

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@johnbley @xrmx @ocelotl @lzchen @srikanthccv