-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log the attribute's key when encoding an attribute fails #3838
Merged
lzchen
merged 8 commits into
open-telemetry:main
from
danielhochman:log-unencodeable-key
Jun 26, 2024
Merged
log the attribute's key when encoding an attribute fails #3838
lzchen
merged 8 commits into
open-telemetry:main
from
danielhochman:log-unencodeable-key
Jun 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@danielhochman you have to sign the CLA for contributing to OpenTelemetry |
emdneto
reviewed
Apr 9, 2024
exporter/opentelemetry-exporter-otlp-proto-common/tests/test_attribute_encoder.py
Outdated
Show resolved
Hide resolved
emdneto
reviewed
Apr 9, 2024
exporter/opentelemetry-exporter-otlp-proto-common/tests/test_attribute_encoder.py
Outdated
Show resolved
Hide resolved
… into log-unencodeable-key
emdneto
reviewed
Jun 24, 2024
exporter/opentelemetry-exporter-otlp-proto-common/tests/test_attribute_encoder.py
Show resolved
Hide resolved
…ttribute_encoder.py Co-authored-by: Emídio Neto <[email protected]>
lzchen
approved these changes
Jun 24, 2024
Please fix the build and add a CHANGELOG entry |
emdneto
approved these changes
Jun 25, 2024
xrmx
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Include the attribute key that failed to encode. Very hard to track down otherwise.
Before
After
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: