Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log the attribute's key when encoding an attribute fails #3838

Merged
merged 8 commits into from
Jun 26, 2024
Merged

log the attribute's key when encoding an attribute fails #3838

merged 8 commits into from
Jun 26, 2024

Conversation

danielhochman
Copy link
Contributor

@danielhochman danielhochman commented Apr 5, 2024

Description

Include the attribute key that failed to encode. Very hard to track down otherwise.

Before

Invalid type <class 'NoneType'> of value None

After

Failed to encode key namespace: Invalid type <class 'NoneType'> of value None

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit tests

Does This PR Require a Contrib Repo Change?

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@danielhochman danielhochman requested a review from a team April 5, 2024 18:12
Copy link

linux-foundation-easycla bot commented Apr 5, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@xrmx
Copy link
Contributor

xrmx commented Apr 8, 2024

@danielhochman you have to sign the CLA for contributing to OpenTelemetry

@danielhochman danielhochman requested a review from emdneto June 21, 2024 20:58
@lzchen
Copy link
Contributor

lzchen commented Jun 24, 2024

@danielhochman

Please fix the build and add a CHANGELOG entry

@danielhochman danielhochman requested a review from lzchen June 25, 2024 15:07
@lzchen lzchen merged commit b34294c into open-telemetry:main Jun 26, 2024
269 checks passed
@danielhochman danielhochman deleted the log-unencodeable-key branch June 26, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants