Move shared test code from ext/ to tests/ #559
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opentelemetry-ext-testutil
is a package with shared test classes used by ext packages (right now onlyopentelemetry-ext-flask
). We don't release this package, just import it in other tests.Right now, on each release, we build everything in
ext/
. This means whoever does the release has to remember to exclude this package when they push the others to PyPI.This PR moves the files and package:
ext/opentelemetry-ext-testutil
->tests/util
opentelemetry.ext.testutil
->opentelemetry.test
This makes maintainers' lives easier, but it does mean that other packages that use testutils will have to install install the
opentelemetry.test
package from source. But this is already the case since we don't publishopentelemetry-ext-testutil
.This PR proposes that we move shared test code back into the main repo until we move a package that depends on it into a separate repo, at which point we'll have to put this code in its own top-level package.