-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump versions to prepare for release v0.22 #1539
Conversation
no. See #1326 tracking issue. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1539 +/- ##
=====================================
Coverage 66.8% 66.8%
=====================================
Files 138 138
Lines 19290 19290
=====================================
Hits 12903 12903
Misses 6387 6387 ☔ View full report in Codecov by Sentry. |
We also need changelog updates as well, similar to https://github.com/open-telemetry/opentelemetry-rust/pull/1343/files |
Added the versions to changelogs. |
Added the @open-telemetry/rust-maintainers group as crates.io owners, so any member should have permissions to manage them now 👍 |
Perhaps we merge #1553 it's a simple change but a good quality of life one. We'd need to rebase due to conflicts, but I think it'd be worth it. |
Perhaps also #1556 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need 2 fixes
- opentelemetry-jaeger - need to indicate this will be the last release of the create
- opentelemetry-jaeger-propagator - use 0.1.0 as version, given this is the very first release.
Rest looks good. Though I am unsure how we decide if the new version is just minor version bump or patch version? like 0.22.0 to 0.23.0 vs 0.22.1? Maybe this is something we'll have sort out and a clear policy going forward, not blocking/delaying this release.
If there is a breaking change it has to be minor version bump before 1.0. Versioning was discussed here https://github.com/open-telemetry/opentelemetry-rust/blob/main/VERSIONING.md |
While I don't disagree with us deprecating it, something that never made it back into the notes of how we'll proceed with properly deprecating. Things to note:
I have created #1560 to address this. Related issue: #995 |
@djc Will you be continuing this PR, resolve the conflicts, so we can do the release ? |
I'm happy to do another pass on the PR once there is a clear set of remaining issues to address, but would prefer to hold off on doing that while some comment threads have not arrived at a resolution. |
There are no open questions now. This release will follow the existing convention, and that is already followed in this PR.
@TommyCpp @hdost Please check if this is good, so that @djc can continue. |
LGTM 👍 |
Yea let's go 🚀 |
BTW, opentelemetry-appender-log does have opentelemetry logs appearing in its public API, so it does actually need a semver-incompatible release number. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@TommyCpp if you want to do the honors of the merge and release this time ? |
I want to get #1562 in before the release but yeah I can do a version release this weekend |
Could we do the release at the earliest, without waiting for 1562? At this stage, we are not merging any other PRs , to avoid interfering with the release, and we don't want to keep other PRs blocked for long.. |
As long as we get #1562 in this weekend and also release, that doesn't seem like a lot of extra delay? |
Between today vs weekend - no diff for me. (for the next release onwards, we can plan and try to get release process complete in under a day) |
Hope this helps. Is the release process written down anywhere?