Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cargo deny #604

Merged
merged 4 commits into from
Jul 30, 2021
Merged

feat: add cargo deny #604

merged 4 commits into from
Jul 30, 2021

Conversation

TommyCpp
Copy link
Contributor

@TommyCpp TommyCpp commented Jul 25, 2021

related to #557

  • Add CI pipeline to check Rust security advisory.
  • Fix the security advisory in the repo.

@TommyCpp TommyCpp marked this pull request as ready for review July 25, 2021 04:41
@TommyCpp TommyCpp requested a review from a team July 25, 2021 04:41
@codecov
Copy link

codecov bot commented Jul 25, 2021

Codecov Report

Merging #604 (9c76fd6) into main (f07cc56) will decrease coverage by 0.3%.
The diff coverage is 8.2%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #604     +/-   ##
=======================================
- Coverage   55.0%   54.7%   -0.4%     
=======================================
  Files        100     101      +1     
  Lines       8889    8945     +56     
=======================================
+ Hits        4896    4897      +1     
- Misses      3993    4048     +55     
Impacted Files Coverage Δ
opentelemetry-jaeger/src/exporter/agent.rs 0.0% <0.0%> (ø)
opentelemetry-jaeger/src/exporter/runtime.rs 0.0% <0.0%> (ø)
opentelemetry-jaeger/src/lib.rs 92.1% <ø> (ø)
opentelemetry-jaeger/src/exporter/mod.rs 47.4% <17.3%> (-0.4%) ⬇️
opentelemetry-jaeger/src/exporter/uploader.rs 26.0% <23.0%> (-16.8%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae4aeb3...9c76fd6. Read the comment docs.

deny.toml Outdated
@@ -0,0 +1,198 @@
# This template contains all of the possible sections and their default values
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer having a minimal config with only the options that are non-default.

@@ -3,6 +3,7 @@ name = "actix-http-tracing"
version = "0.1.0"
edition = "2018"
publish = false
license = "Apache-2.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of this, I usually set publish = false in Cargo.toml and then enable ignoring private crates in deny.toml. But maybe it's useful to explicitly license the examples in this case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that depends on the policy of opentelemetry org. But we should add publish = false regardless

@TommyCpp TommyCpp merged commit d3bbfd2 into open-telemetry:main Jul 30, 2021
@TommyCpp
Copy link
Contributor Author

close #557

@TommyCpp TommyCpp deleted the cargo_deny branch August 17, 2021 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants