-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add cargo deny #604
feat: add cargo deny #604
Conversation
Codecov Report
@@ Coverage Diff @@
## main #604 +/- ##
=======================================
- Coverage 55.0% 54.7% -0.4%
=======================================
Files 100 101 +1
Lines 8889 8945 +56
=======================================
+ Hits 4896 4897 +1
- Misses 3993 4048 +55
Continue to review full report at Codecov.
|
deny.toml
Outdated
@@ -0,0 +1,198 @@ | |||
# This template contains all of the possible sections and their default values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer having a minimal config with only the options that are non-default.
@@ -3,6 +3,7 @@ name = "actix-http-tracing" | |||
version = "0.1.0" | |||
edition = "2018" | |||
publish = false | |||
license = "Apache-2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of this, I usually set publish = false
in Cargo.toml
and then enable ignoring private crates in deny.toml
. But maybe it's useful to explicitly license the examples in this case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess that depends on the policy of opentelemetry org. But we should add publish = false
regardless
close #557 |
related to #557