Skip to content

Commit

Permalink
Remove the recommendation to not synchronize access to Config.disabled (
Browse files Browse the repository at this point in the history
  • Loading branch information
pellared authored Dec 5, 2024
1 parent 50027a1 commit 19d6783
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,22 @@ release.

- Add in-development support for `otlp/stdout` exporter via `OTEL_TRACES_EXPORTER`.
([#4183](https://github.com/open-telemetry/opentelemetry-specification/pull/4183))
- Remove the recommendation to not synchronize access to `TracerConfig.disabled`.
([#4310](https://github.com/open-telemetry/opentelemetry-specification/pull/4310))

### Metrics

- Add in-development support for `otlp/stdout` exporter via `OTEL_METRICS_EXPORTER`.
([#4183](https://github.com/open-telemetry/opentelemetry-specification/pull/4183))
- Remove the recommendation to not synchronize access to `MeterConfig.disabled`.
([#4310](https://github.com/open-telemetry/opentelemetry-specification/pull/4310))

### Logs

- Add in-development support for `otlp/stdout` exporter via `OTEL_LOGS_EXPORTER`.
([#4183](https://github.com/open-telemetry/opentelemetry-specification/pull/4183))
- Remove the recommendation to not synchronize access to `LoggerConfig.disabled`.
([#4310](https://github.com/open-telemetry/opentelemetry-specification/pull/4310))

### Events

Expand Down
4 changes: 1 addition & 3 deletions specification/logs/sdk.md
Original file line number Diff line number Diff line change
Expand Up @@ -190,9 +190,7 @@ It consists of the following parameters:
is [Enabled](./api.md#enabled). If `disabled` is `true`, `Enabled`
returns `false`. If `disabled` is `false`, `Enabled` returns `true`. It is not
necessary for implementations to ensure that changes to `disabled` are
immediately visible to callers of `Enabled`. I.e. atomic, volatile,
synchronized, or equivalent memory semantics to avoid stale reads are
discouraged to prioritize performance over immediate consistency.
immediately visible to callers of `Enabled`.

## Additional LogRecord interfaces

Expand Down
4 changes: 1 addition & 3 deletions specification/metrics/sdk.md
Original file line number Diff line number Diff line change
Expand Up @@ -973,9 +973,7 @@ default `MeterConfig.disabled=false` and instruments use the default
aggregation when no matching views match the instrument.

It is not necessary for implementations to ensure that changes
to `MeterConfig.disabled` are immediately visible to callers of `Enabled`. I.e.
atomic, volatile, synchronized, or equivalent memory semantics to avoid stale
reads are discouraged to prioritize performance over immediate consistency.
to `MeterConfig.disabled` are immediately visible to callers of `Enabled`.

## Attribute limits

Expand Down
4 changes: 1 addition & 3 deletions specification/trace/sdk.md
Original file line number Diff line number Diff line change
Expand Up @@ -184,9 +184,7 @@ It consists of the following parameters:
is [Enabled](./api.md#enabled). If `disabled` is `true`, `Enabled`
returns `false`. If `disabled` is `false`, `Enabled` returns `true`. It is not
necessary for implementations to ensure that changes to `disabled` are
immediately visible to callers of `Enabled`. I.e. atomic, volatile,
synchronized, or equivalent memory semantics to avoid stale reads are
discouraged to prioritize performance over immediate consistency.
immediately visible to callers of `Enabled`.

## Additional Span Interfaces

Expand Down

0 comments on commit 19d6783

Please sign in to comment.