Skip to content

Commit

Permalink
lint
Browse files Browse the repository at this point in the history
  • Loading branch information
lmolkova committed Nov 30, 2022
1 parent bbea228 commit 9b249a9
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
4 changes: 2 additions & 2 deletions schemas/1.16.0
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ schema_url: https://opentelemetry.io/schemas/1.16.0
versions:
1.16.0:
spans:
# https://github.com/open-telemetry/opentelemetry-specification/pull/2763
changes:
# https://github.com/open-telemetry/opentelemetry-specification/pull/2763
- rename_attributes:
attribute_map:
messaging.consumer_id: messaging.consumer.id
Expand All @@ -24,7 +24,7 @@ versions:
messaging.rocketmq.message_type: messaging.rocketmq.message.type
messaging.rocketmq.message_tag: messaging.rocketmq.message.tag
messaging.rocketmq.message_keys: messaging.rocketmq.message.keys
messaging.kafka.consumer_group -> messaging.kafka.consumer.group
messaging.kafka.consumer_group: messaging.kafka.consumer.group
1.15.0:
spans:
changes:
Expand Down
4 changes: 2 additions & 2 deletions semantic_conventions/trace/messaging.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -229,10 +229,10 @@ groups:
recommended: If known on consumer
- ref: messaging.destination.temporary
requirement_level:
recommended: If known on consumer
recommended: If known on consumer
- ref: messaging.destination.anonymous
requirement_level:
recommended: If known on consumer
recommended: If known on consumer

- id: messaging.consumer.synchronous
prefix: messaging
Expand Down
1 change: 0 additions & 1 deletion specification/trace/semantic_conventions/messaging.md
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,6 @@ For batch receiving and processing (see the [Batch receiving](#batch-receiving)
Even though in that case one might think that the processing span's kind should be `INTERNAL`, that kind MUST NOT be used.
Instead span kind should be set to either `CONSUMER` or `SERVER` according to the rules defined above.


> Note: Consumer spans can have attributes describing source and destination. Since messages could be routed by brokers, source and destination don't always match. If original destination information is available on the consumer, consumer instrumentations SHOULD populate corresponding `messaging.destination` attributes.
### Per-message attributes
Expand Down

0 comments on commit 9b249a9

Please sign in to comment.