-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tls support for exporters #142
Comments
What does TLS stands for in this context? |
@SergeyKanzhelev for example, the zipkin exporter, it doesn't have an option to pass in an SSLContext where we could send the data to an https endpoint. |
@bputt whether an exporter supports TLS or not is up to the exporter. Agreed, depending on the configuration, TLS may be a requirement. Some exporters, such as the opencensus exporter, support TLS today. Is the purpose of this issue to standard the configuration parameters for TLS in an exporter? |
@flands Yes, have some standardization that allows TLS to be put into place within an exporter |
Got it -- to that end, there are multiple common parameters that exporters should standardize on beyond TLS. Some common ones today:
Today, @SergeyKanzhelev is the point of the specification for API definition only? If so, where should receiver/exporter standards live? If not, I will create a section for receivers and exporters and put up a PR. |
@flands that was the first iteration. The intention to specify SDK as well. This set of settings is a good one. |
@SergeyKanzhelev @flands Not sure if it was implied or not, but if I added |
Closing this -- it's uncontroversial that we will support secure transport for TCP connections. |
Update changelog with complete change since 1.0.0.
We've extended opencensus to use tls for zipkin exporter and imagine it would be helpful to others if tls was an option for all exporters.
Should the spec include TLS for exporting? I know this doesn't matter for certain cloud providers, but for non-cloud native environments, it's required (whether we setup a local proxy that adds tls or if the exporter supported it out of the box (which would be ideal))
The text was updated successfully, but these errors were encountered: