Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go: Add Registering Views #3275

Merged
merged 22 commits into from
Sep 18, 2023
Merged

Go: Add Registering Views #3275

merged 22 commits into from
Sep 18, 2023

Conversation

pellared
Copy link
Member

@pellared pellared commented Sep 15, 2023 •
edited
Loading

Towards open-telemetry/opentelemetry-go#3186

I will add examples showing how to drop metrics/attributes in a separate PR when open-telemetry/opentelemetry-go#4527 is merged.

The content is based on:

Docs PR Checklist

  • This PR is for a documentation page whose authoritative copy is in the
    opentelemetry.io repository.

@pellared pellared marked this pull request as ready for review September 15, 2023 09:43
@pellared pellared requested review from a team September 15, 2023 09:43
theletterf
theletterf requested changes Sep 15, 2023
View reviewed changes
content/en/docs/instrumentation/go/manual.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/go/manual.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/go/manual.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/go/manual.md Outdated Show resolved Hide resolved
@pellared pellared requested a review from a team September 15, 2023 10:30
@pellared pellared requested a review from theletterf September 15, 2023 10:34
dashpole
dashpole reviewed Sep 15, 2023
View reviewed changes
content/en/docs/instrumentation/go/manual.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/go/manual.md Outdated Show resolved Hide resolved
content/en/docs/instrumentation/go/manual.md Show resolved Hide resolved
content/en/docs/instrumentation/go/manual.md Outdated Show resolved Hide resolved
@pellared pellared mentioned this pull request Sep 15, 2023
Merged
@pellared pellared requested a review from dashpole September 15, 2023 16:38
@pellared pellared mentioned this pull request Sep 18, 2023
Closed
@pellared pellared marked this pull request as draft September 18, 2023 08:57
@pellared pellared marked this pull request as ready for review September 18, 2023 09:21
@pellared
Copy link
Member Author

@cartermp Ready for review 😉

@cartermp cartermp merged commit 5cb4b0d into open-telemetry:main Sep 18, 2023
@cartermp
Copy link
Contributor

Thanks, great changes!

@pellared pellared deleted the go-views branch September 18, 2023 16:46
@pellared pellared mentioned this pull request Sep 19, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartermp cartermp cartermp approved these changes

@dashpole dashpole dashpole approved these changes

@theletterf theletterf theletterf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pellared @cartermp @theletterf @dashpole