-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add container parser blog post #4489
Merged
svrnm
merged 6 commits into
open-telemetry:main
from
ChrsMark:add_container_parser_blog_post
May 22, 2024
+231
−0
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c47b246
add container parser blogpost
ChrsMark 9fc5d8a
switch to single voice
ChrsMark db56d91
add note about reduced configuration
ChrsMark 07bddcc
Merge branch 'main' into add_container_parser_blog_post
svrnm eba145b
Merge branch 'main' into add_container_parser_blog_post
svrnm c472855
Merge branch 'main' into add_container_parser_blog_post
svrnm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
add note about reduced configuration
Signed-off-by: ChrsMark <[email protected]>
commit db56d910d3800f9ca693196c017d9db2bd653dda
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about showing the comparison to the config previously (with the container parser) required (that you mention in the issue above: open-telemetry/opentelemetry-collector-contrib#31959)?
Or at least mention that the config now is 8 lines long vs. ~80 lines to achieve the same result.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! Added at 44778bd, thank's.