Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collisions: manual conflict resolution #76

Closed
wants to merge 8 commits into from

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented Jun 9, 2024

Alternative to #75:

  • _ and . are rendered the same in the code
  • semconv policy does not allow to have non-deprecated attributes with the same const name.
  • semconv policy allows to have a collision with a deprecated attribute
  • there is a manual conflict resolution way that allows to change constant names for arbitrary attributes and/or drop them

@lmolkova lmolkova changed the title Collisions: option 3 - tolerate collisions with deprecated attributes, v1.26.0 Collisions: manual conflict resolution Jun 11, 2024
@lmolkova lmolkova force-pushed the collisions-option-3 branch from fa08982 to 75fa817 Compare June 11, 2024 22:06
Comment on lines +90 to +91
val nameMapping = """{\"http.request.method\":\"http.request.method_new\"}"""
val excludedAttributes = """[\"http.flavor\"]"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lmolkova lmolkova closed this Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants