-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cicd] add initial cicd attributes to registry #1075
Conversation
Adjusts the original deployment environment attribute to match proposal.
This pull request comes out of #915. Notably, this comment on the issue. I additionally added the As of the time of writing this comment, this pull request does not address the filling:
Will be having some convo's this week & iterating as necessary. Additionally, I noticed This begs the question, should I separate out each namespace (ie. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes from our discussion! Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for this huge PR and work, you have put into it.
I just left minor comments, but they are not affecting my approval
Adds proposed CICD common attributes to the registry.
Fixes #915
Changes
Please provide a brief description of the changes here.
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist
[chore]