Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved Service attributes to registry #758

Merged
merged 11 commits into from
Apr 3, 2024

Conversation

gregkalapos
Copy link
Member

Changes

This PR is to moves service and service_experimental attributes to the attributes registry and make service resources reference the registry.

Merge requirement checklist

@gregkalapos gregkalapos requested review from a team February 19, 2024 19:32
@joaopgrassi joaopgrassi added the Skip Changelog Label to skip the changelog check label Feb 20, 2024
@joaopgrassi
Copy link
Member

@gregkalapos can you please fix the yamllint issues? then we should be good to merge :)

docs/resource/README.md Outdated Show resolved Hide resolved
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@trisch-me
Copy link
Contributor

@gregkalapos could you please update this PR?

@gregkalapos
Copy link
Member Author

gregkalapos commented Mar 27, 2024

This is still pending on #820. I think #820 should be merged first and then I could update this.

Alternatively I could use the changes from #820, update this PR and maybe we could merge - I personally don't think that'd be ok, but happy to do so if others think it makes sense.

My understanding is that @lmolkova also wanted to merge #820 first and then update this PR, see: #807

Let me know how to proceed - otherwise I'll just wait for #820.

@gregkalapos gregkalapos force-pushed the MoveServiceToRegistry branch from 89425f8 to be863c4 Compare March 28, 2024 20:43
@gregkalapos gregkalapos requested a review from trisch-me March 28, 2024 20:45
@gregkalapos
Copy link
Member Author

gregkalapos commented Mar 28, 2024

#820 merged, I updated this PR.

@gregkalapos
Copy link
Member Author

gregkalapos commented Mar 28, 2024

Currently fighting with areas-dropdown-check.

`Dropdowns in issue templates is out of date, please run "make generate-gh-issue-templates" and commit the changes in this PR.
Error: Process completed with exit code 1.

make generate-gh-issue-templates fails for me locally - trying to figure this out... 😢

Update: managed to run it, and pushed it. Issue was around sed on my mac - installed gsed, that worked.

@joaopgrassi joaopgrassi merged commit be971ee into open-telemetry:main Apr 3, 2024
11 checks passed
@trisch-me
Copy link
Contributor

@gregkalapos I had the same issue, have created a hint for it
https://github.com/open-telemetry/semantic-conventions/pull/876/files
@joaopgrassi FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Label to skip the changelog check
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants