-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved Service attributes to registry #758
Moved Service attributes to registry #758
Conversation
@gregkalapos can you please fix the yamllint issues? then we should be good to merge :) |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
@gregkalapos could you please update this PR? |
This is still pending on #820. I think #820 should be merged first and then I could update this. Alternatively I could use the changes from #820, update this PR and maybe we could merge - I personally don't think that'd be ok, but happy to do so if others think it makes sense. My understanding is that @lmolkova also wanted to merge #820 first and then update this PR, see: #807 Let me know how to proceed - otherwise I'll just wait for #820. |
89425f8
to
be863c4
Compare
#820 merged, I updated this PR. |
Currently fighting with areas-dropdown-check.
Update: managed to run it, and pushed it. Issue was around |
@gregkalapos I had the same issue, have created a hint for it |
Changes
This PR is to moves
service
andservice_experimental
attributes to the attributes registry and make service resources reference the registry.Merge requirement checklist
[chore]