HTTP spans restructuring: explicitly list all http client and server attributes, remove common #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
commented
Apr 18, 2024
joaopgrassi
approved these changes
Apr 18, 2024
jsuereth
approved these changes
Apr 18, 2024
|
/cc @trask |
trask
approved these changes
Apr 18, 2024
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #928
Changes
Having common attributes section in HTTP spans could be confusing - readers are probably interested in a full specification for client or for server.
Another problem is that the way yaml is organized now makes it impossible to resolve the full list of attributes HTTP client and server should report.
This PR removes common yaml group and moves common attributes into client and server groups.
Merge requirement checklist
[chore]schema-next.yaml updated with changes to existing conventions.