add pretest #396
Merged
add pretest #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashutshkumr
reviewed
Jul 2, 2021
do.py
Outdated
| @@ -36,6 +36,15 @@ def lint(): | |||
|
|
|||
|
|
|||
| def test(): | |||
| pretest_args = [ | |||
There was a problem hiding this comment.
we shouldn't write another test and run them separately.
the goal is to run some code automatically before starting all tests. This can be done using pytest fixtures.
ashutshkumr
reviewed
Jul 2, 2021
| config.ports.port(name="port%d" % i, location=utils.settings.ports[i])[ | ||
| -1 | ||
| ] | ||
|
|
There was a problem hiding this comment.
Have we tested that this works if we cancel pipeline while the test is running and then restart pipeline ?
ashutshkumr
approved these changes
Jul 2, 2021
ashutshkumr
requested changes
Jul 2, 2021
|
Closing as #399 already fixes the underlying issue. |
|
@alakendu & @Rangababu-R : Please suggest any pointer discussed during the meeting |
ashutshkumr
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add pretest