This repository has been archived by the owner on Oct 25, 2024. It is now read-only.
59 server #4
Closed
59 server #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ix are both obvious, WindowCapturerWin should not return Result::SUCCESS with an empty frame. This issue was original introduced into the code base in change https://codereview.webrtc.org/1988783003/. I am also considering whether we should move the previous_size_ = frame->size(); window_size_map_[window_] = previous_size_; into the true branch. But since this change needs to be merged into M58 and M59, I would prefer to keep it as small as possible. BUG=712615 Review-Url: https://codereview.webrtc.org/2835553002 Cr-Commit-Position: refs/heads/master@{#17799} (cherry picked from commit d41af46) Review-Url: https://codereview.webrtc.org/2834923002 . Cr-Commit-Position: refs/branch-heads/59@{#2} Cr-Branched-From: 10d095d-refs/heads/master@{#17657}
This CL is a merge of 103ac7e into M59. This CL adds tuning to AEC3 for the purpose of reducing the impact of gain changes in the analog microphone gain. NOTRY=true NOPRESUBMIT=true BUG=chromium:710818, webrtc:6018 Review-Url: https://codereview.webrtc.org/2811283003 Cr-Commit-Position: refs/heads/master@{#17673} (cherry picked from commit 103ac7e) Review-Url: https://codereview.webrtc.org/2833643003 Cr-Commit-Position: refs/branch-heads/59@{#3} Cr-Branched-From: 10d095d-refs/heads/master@{#17657}
…he incoming frame, and if so, clear the FrameBuffer. BUG=chromium:679306 Review-Url: https://codereview.webrtc.org/2830723002 Cr-Commit-Position: refs/heads/master@{#17785} (cherry picked from commit 146a48b) [email protected] Review-Url: https://codereview.webrtc.org/2835963002 . Cr-Commit-Position: refs/branch-heads/59@{#4} Cr-Branched-From: 10d095d-refs/heads/master@{#17657}
This is a merge of the CL https://codereview.webrtc.org/2823903003 into M59. This CL improves the echo cancellation performance on setups where headsets are used (systems with such low echo path gain that no correlation between the render and capture signals can be found) in 4 ways: 1) The echo path gain for systems with headsets is assumed to be nonzero. 2) The stationary component of the render power is not included in nonlinear echo power estimate. 3) The behavior after echo path gain changes is made less cautious. 4) The detection of systems with headsets is made more rapid. NOTRY=true NOPRESUBMIT=true BUG=chromium:712651, webrtc:6018 Review-Url: https://codereview.webrtc.org/2823903003 Cr-Commit-Position: refs/heads/master@{#17768} (cherry picked from commit e52a203) Review-Url: https://codereview.webrtc.org/2833353002 Cr-Commit-Position: refs/branch-heads/59@{#5} Cr-Branched-From: 10d095d-refs/heads/master@{#17657}
BUG=chromium:710812 Review-Url: https://codereview.webrtc.org/2814363002 Cr-Commit-Position: refs/heads/master@{#17835} (cherry picked from commit 0f109be) Review-Url: https://codereview.webrtc.org/2835423002 . Cr-Commit-Position: refs/branch-heads/59@{#6} Cr-Branched-From: 10d095d-refs/heads/master@{#17657}
…derruns This CL contains a merge of the cl debaa44 into the branch M59. This CL corrects the behavior in AEC3 during buffer overruns and underruns in three ways. 1) When there is no render signal available (due to a buffering issues, a zero block is inserted instead of the previous render block. This avoids the same block being repeatedly inserted when there are many back-to-back calls. 2) The internal counters in the main adaptive filter gain are also reset when the filter is reset. 3) The internal counters in the shadow adaptive filter gain are reset when the filter is reset. NOTRY=true NOPRESUBMIT=true BUG=chromium:717920,webrtc:7559 Review-Url: https://codereview.webrtc.org/2862533002 Cr-Commit-Position: refs/heads/master@{#17991} (cherry picked from commit debaa44) Review-Url: https://codereview.webrtc.org/2862683002 Cr-Commit-Position: refs/branch-heads/59@{#7} Cr-Branched-From: 10d095d-refs/heads/master@{#17657}
The key change of this CL is to merge ScreenCapturerWinDirectx::frames_ and contexts_ into a new DxgiFrame class. So consumers of DxgiDuplicateController does not need to maintain two objects. DxgiDuplicateController::Duplicate*() functions are also updated to accept DxgiFrame parameter instead of SharedDesktopFrame + Context. The advantages of this change are, 1. Once the screen resolution changes or an existing monitor has been removed, DxgiFrame can automatically reset the frame without needing to return a capture failure. 2. Remove public APIs of DxgiDuplicatorController. Some public APIs are not needed anymore, i.e. consumers of DxgiDuplicatorController do not need to take care about these internal states anymore. It also helps to remove several lock acquiements. 3. Reduce the complexity of ScreenCapturerWinDirectx. But the disadvantage is, instead of a boolean value, DxgiDuplicateController::Duplicate*() now return an enumeration. Clients need to use the enumeration to decide whether the error can be recovered or not. This change also removes a duplicating logic in ScreenCapturerWinDirectx. i.e. ResolutionChangeDetector, DxgiDuplicateController now takes care of the screen resolution changes. I have verified the scenarios with and without SharedMemoryFactory, also the Desktop capture API example. So far no regression is detected. BUG=704205, 715689 Review-Url: https://codereview.webrtc.org/2788863006 Cr-Commit-Position: refs/heads/master@{#17795} (cherry picked from commit cf5753d) Review-Url: https://codereview.webrtc.org/2860573010 . Cr-Commit-Position: refs/branch-heads/59@{#8} Cr-Branched-From: 10d095d-refs/heads/master@{#17657}
Windows may return a DesktopCoordinate out of the first quadrant (x >= 0 && y >= 0), this typically happens when the primary and secondary monitors are swapped. i.e. The secondary monitor is on the left but the primary one is on the right. This change "moves" the entire screen from any quadrant to the (0, 0), so we can capture the monitors in other quadrants. BUG=chromium:715689 Review-Url: https://codereview.webrtc.org/2848443004 Cr-Original-Commit-Position: refs/heads/master@{#17935} Committed: https://chromium.googlesource.com/external/webrtc/+/049ec71e657eef3d15e0f15d60acb1a71e81b521 Review-Url: https://codereview.webrtc.org/2848443004 Cr-Commit-Position: refs/heads/master@{#17938} (cherry picked from commit 419c742) Review-Url: https://codereview.webrtc.org/2866493002 . Cr-Commit-Position: refs/branch-heads/59@{#9} Cr-Branched-From: 10d095d-refs/heads/master@{#17657}
BUG=webrtc:7590 Review-Url: https://codereview.webrtc.org/2870823003 Cr-Original-Commit-Position: refs/heads/master@{#18086} Review-Url: https://codereview.webrtc.org/2890943002 . Cr-Commit-Position: refs/branch-heads/59@{#10} Cr-Branched-From: 10d095d-refs/heads/master@{#17657}
…at RtpFrameReferenceFinder. BUG=chromium:679306 [email protected] [email protected] Review-Url: https://codereview.webrtc.org/2879073002 Cr-Commit-Position: refs/heads/master@{#18140} (cherry picked from commit e95b78b) Review-Url: https://codereview.webrtc.org/2891073002 . Cr-Commit-Position: refs/branch-heads/59@{#11} Cr-Branched-From: 10d095d-refs/heads/master@{#17657}
…n the PacketBuffer for H264 frames. BUG=webrtc:7532, chromium:724031 [email protected] Review-Url: https://codereview.webrtc.org/2868723003 Cr-Original-Commit-Position: refs/heads/master@{#18191} Review-Url: https://codereview.webrtc.org/2899713002 . Cr-Commit-Position: refs/branch-heads/59@{#12} Cr-Branched-From: 10d095d-refs/heads/master@{#17657}
Packet::GetHeader() wasn't copying playout_delay. As result playout_delay was ignored when flexfec is enabled. Patch by Rob McCool <[email protected]> BUG=webrtc:7590 Review-Url: https://codereview.webrtc.org/2899553003 Cr-Commit-Position: refs/heads/master@{#18218} (cherry picked from commit b2c001a) BUG=chromium:722490 Review-Url: https://codereview.webrtc.org/2898813002 . Cr-Commit-Position: refs/branch-heads/59@{#13} Cr-Branched-From: 10d095d-refs/heads/master@{#17657}
…cketBuffer. BUG=chromium:719095 Review-Url: https://codereview.webrtc.org/2889163003 Cr-Original-Commit-Position: refs/heads/master@{#18214} Review-Url: https://codereview.webrtc.org/2916433003 . Cr-Commit-Position: refs/branch-heads/59@{#14} Cr-Branched-From: 10d095d-refs/heads/master@{#17657}
BUG=webrtc:7700 Review-Url: https://codereview.webrtc.org/2902743002 Cr-Original-Commit-Position: refs/heads/master@{#18237} Review-Url: https://codereview.webrtc.org/2914683002 . Cr-Commit-Position: refs/branch-heads/59@{#15} Cr-Branched-From: 10d095d-refs/heads/master@{#17657}
The signal was only being hooked up for incoming connections, not outgoing connections. As a result, the bandwidth estimator didn't know when packets were sent and couldn't calculate delays. BUG=webrtc:7509 [email protected] NOTRY=True NOPRESUBMIT=True Original Review-Url: https://codereview.webrtc.org/2834083002 Original Cr-Commit-Position: refs/heads/master@{#17817} (cherry picked from commit 0687829) Review-Url: https://codereview.webrtc.org/2917223002 Cr-Commit-Position: refs/branch-heads/59@{#16} Cr-Branched-From: 10d095d-refs/heads/master@{#17657}
Signed-off-by: jdai12 <[email protected]>
2. gitignore tmp Signed-off-by: jdai12 <[email protected]>
2. Remove ssl dependency 3. Simplify webrtc-base 4. Add woogeen ffmpeg and openh264 dependency in video_coding Signed-off-by: jdai12 <[email protected]> Change-Id: I12950d6e20c2812b0b51ab9e3908c3bc094ba11b Reviewed-on: https://git-ccr-1.devtools.intel.com/gerrit/55760 Reviewed-by: Qiu, Jianlin <[email protected]> Tested-by: Qiu, Jianlin <[email protected]>
Signed-off-by: jdai12 <[email protected]> Change-Id: I149ed3a06df9da143fdca0e2444f87463840faff Reviewed-on: https://git-ccr-1.devtools.intel.com/gerrit/56035
Signed-off-by: jdai12 <[email protected]> Change-Id: I504e0834a2f64f3be5c7c4bdba83b69c12fc415c Reviewed-on: https://git-ccr-1.devtools.intel.com/gerrit/56090
Signed-off-by: jdai12 <[email protected]> Change-Id: Ife76712d9c97f4b579590270539aaaa0dc48d7e1 Reviewed-on: https://git-ccr-1.devtools.intel.com/gerrit/56099
Signed-off-by: jdai12 <[email protected]> Change-Id: I7fb75697da97a33baf330d72a1f83a2eb502ff40 Reviewed-on: https://git-ccr-1.devtools.intel.com/gerrit/56180 Reviewed-by: Duan, Xiande <[email protected]> Tested-by: Duan, Xiande <[email protected]>
Signed-off-by: jdai12 <[email protected]> Change-Id: I0d18ab40d09eb97c7b5724702de9950cbb59ca6a Reviewed-on: https://git-ccr-1.devtools.intel.com/gerrit/56241
in h264 decoder Signed-off-by: jdai12 <[email protected]> Change-Id: If1386d932d68974bfa39521102d2be83951bad89 Reviewed-on: https://git-ccr-1.devtools.intel.com/gerrit/56529 Reviewed-by: Duan, Xiande <[email protected]> Tested-by: Duan, Xiande <[email protected]>
Add pcm 48khz stereo payload type. Signed-off-by: jdai12 <[email protected]> Change-Id: I12d95f6a8fabbef740e8ab4719a941c49d4a283b Reviewed-on: https://git-ccr-1.devtools.intel.com/gerrit/56489 Reviewed-by: Duan, Xiande <[email protected]> Tested-by: Duan, Xiande <[email protected]>
Change-Id: I8be554e0548465cf49c13a8adf3db80379b5d39a Reviewed-on: https://git-ccr-1.devtools.intel.com/gerrit/60267 Reviewed-by: Zhu, Jianjun <[email protected]> Reviewed-by: Dai, Jianhui J <[email protected]> Tested-by: Dai, Jianhui J <[email protected]>
Signed-off-by: jdai12 <[email protected]> Change-Id: Iab60c9c66c52ee7ac27d29a1f24370f5228a22b2 Reviewed-on: https://git-ccr-1.devtools.intel.com/gerrit/61891 Reviewed-by: Duan, Xiande <[email protected]> Tested-by: Duan, Xiande <[email protected]>
Change-Id: I6ca50accceb754e8bc537a88c09c1feec1023ded Reviewed-on: https://git-ccr-1.devtools.intel.com/gerrit/63755 Reviewed-by: Dai, Jianhui J <[email protected]> Reviewed-by: Duan, Xiande <[email protected]> Tested-by: Duan, Xiande <[email protected]>
Signed-off-by: jdai12 <[email protected]> Change-Id: I08d6b4e7b8aff5c747c176377d80f6eaefa68f36 Reviewed-on: https://git-ccr-1.devtools.intel.com/gerrit/63697 Reviewed-by: Duan, Xiande <[email protected]> Tested-by: Duan, Xiande <[email protected]>
Change-Id: If7400adac757c7d2344a7383b4eb07d398deea79 Reviewed-on: https://git-ccr-1.devtools.intel.com/gerrit/64386 Reviewed-by: Qiu, Jianlin <[email protected]> Tested-by: Qiu, Jianlin <[email protected]>
Signed-off-by: Dai, Jianhui <[email protected]> Change-Id: I74922967e84fe7525bb8b4a9f8a69748cf0decca Reviewed-on: https://git-ccr-1.devtools.intel.com/gerrit/74246 Reviewed-by: Duan, Xiande <[email protected]> Tested-by: Duan, Xiande <[email protected]>
…ger send SC Change-Id: I166225be2d52ae1e8d10de76d6b9aacb3c9cd9f0 Reviewed-on: https://git-ccr-1.devtools.intel.com/gerrit/78818 Reviewed-by: Qiu, Jianlin <[email protected]> Tested-by: Qiu, Jianlin <[email protected]>
_VAD_METHOD_ENERGY_
_VAD_METHOD_VOICE_DETECTION_ (default)
_VAD_METHOD_JOINT_ENERGY_VOICE_DETECTION_
Signed-off-by: Dai, Jianhui <[email protected]>
Change-Id: I2709324989624fa6aa1c069f153e10e7077c1035
Reviewed-on: https://git-ccr-1.devtools.intel.com/gerrit/86078
Reviewed-by: Duan, Xiande <[email protected]>
Tested-by: Duan, Xiande <[email protected]>
Change-Id: Ieccb668215049164b31562dc7466592c0deccbaa Reviewed-on: https://git-ccr-1.devtools.intel.com/gerrit/95930 Reviewed-by: Dai, Jianhui J <[email protected]> Reviewed-by: Duan, Xiande <[email protected]> Tested-by: Duan, Xiande <[email protected]>
Change-Id: I0c975533b600cd0866d3b7171674c923aaad6f4f Reviewed-on: https://git-ccr-1.devtools.intel.com/gerrit/99532 Tested-by: webrtctest <[email protected]> Reviewed-by: Duan, Xiande <[email protected]>
… stream Change-Id: I082927618aef2eae1cc1ec392158a1173fd4f80c Reviewed-on: https://git-ccr-1.devtools.intel.com/gerrit/99718 Tested-by: webrtctest <[email protected]> Reviewed-by: Dai, Jianhui J <[email protected]> Reviewed-by: Qiu, Jianlin <[email protected]>
starwarfan
requested review from
jianjunz,
lzhai and
taste1981
and removed request for
jianjunz,
lzhai and
taste1981
taste1981
pushed a commit
that referenced
this pull request
Dec 30, 2020
This reverts commit 76d3e7a. Reason for revert: Causes multiple Chromium WPT tests to crash, preventing rolls. Sample failed run: https://ci.chromium.org/p/chromium/builders/try/win10_chromium_x64_rel_ng/685757? Sample stack trace: #0 0x7ff8623fbde9 base::debug::CollectStackTrace() STDERR: #1 0x7ff862311ca3 [2665012:17:1009/162250.249660:WARNING:timestamp_aligner.cc(131)] too short translated timestamp interval: system time (us) = 3042652370324, interval (us) = 834 STDERR: base::debug::StackTrace::StackTrace() STDERR: #2 0x7ff8623fb93b base::debug::(anonymous namespace)::StackDumpSignalHandler() STDERR: #3 0x7ff857a70140 [2665012:17:1009/162250.249947:WARNING:timestamp_aligner.cc(131)] too short translated timestamp interval: system time (us) = 3042652370634, interval (us) = 742 STDERR: (/lib/x86_64-linux-gnu/libpthread-2.31.so+0x1413f) STDERR: #4 0x7ff85778edb1 gsignal STDERR: #5 0x7ff857778537 abort STDERR: #6 0x7ff855d5eee2 [2665012:17:1009/162250.250342:WARNING:timestamp_aligner.cc(131)] too short translated timestamp interval: system time (us) = 3042652371030, interval (us) = 706 STDERR: [2665012:17:1009/162250.250514:WARNING:timestamp_aligner.cc(131)] too short translated timestamp interval: system time (us) = 3042652371204, interval (us) = 963 STDERR: rtc::webrtc_checks_impl::FatalLog() STDERR: #7 0x7ff855f14e62 webrtc::LibvpxVp8Encoder::PrepareRawImagesForEncoding() STDERR: #8 0x7ff855f14412 webrtc::LibvpxVp8Encoder::Encode() STDERR: #9 0x7ff855bae765 webrtc::SimulcastEncoderAdapter::Encode() STDERR: #10 0x7ff85607d598 webrtc::VideoStreamEncoder::EncodeVideoFrame() STDERR: #11 0x7ff85607c60d webrtc::VideoStreamEncoder::MaybeEncodeVideoFrame() STDERR: #12 0x7ff8560816f5 webrtc::webrtc_new_closure_impl::ClosureTask<>::Run() STDERR: #13 0x7ff855b352b5 (anonymous namespace)::WebrtcTaskQueue::RunTask() STDERR: #14 0x7ff855b3531e base::internal::Invoker<>::RunOnce() STDERR: #15 0x7ff86239785b base::TaskAnnotator::RunTask() STDERR: #16 0x7ff8623c8557 base::internal::TaskTracker::RunSkipOnShutdown() STDERR: #17 0x7ff8623c7d92 base::internal::TaskTracker::RunTask() STDERR: #18 0x7ff862415a06 base::internal::TaskTrackerPosix::RunTask() STDERR: #19 0x7ff8623c75e6 base::internal::TaskTracker::RunAndPopNextTask() STDERR: #20 0x7ff8623d3a8d base::internal::WorkerThread::RunWorker() STDERR: #21 0x7ff8623d368d base::internal::WorkerThread::RunPooledWorker() STDERR: #22 0x7ff862416509 base::(anonymous namespace)::ThreadFunc() STDERR: #23 0x7ff857a64ea7 start_thread Original change's description: > NV12 support for VP8 simulcast > > Tested using video_loopback with generated NV12 frames. > > Bug: webrtc:11635, webrtc:11975 > Change-Id: I14b2d663c55a83d80e48e226fcf706cb18903193 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/186722 > Commit-Queue: Evan Shrubsole <[email protected]> > Reviewed-by: Ilya Nikolaevskiy <[email protected]> > Cr-Commit-Position: refs/heads/master@{#32325} [email protected],[email protected] # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:11635 Bug: webrtc:11975 Change-Id: I61c8aed1270bc9c2f7f0577fa5ca717a325f548a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/187484 Reviewed-by: Guido Urdaneta <[email protected]> Reviewed-by: Ilya Nikolaevskiy <[email protected]> Commit-Queue: Guido Urdaneta <[email protected]> Cr-Commit-Position: refs/heads/master@{#32369}
taste1981
pushed a commit
that referenced
this pull request
Dec 30, 2020
This reverts commit c5f7108. Reason for revert: Causes Chromium WPT Tests to fail, preventing rolls. Sample failed run: https://ci.chromium.org/p/chromium/builders/try/linux-rel/511995? Sample logs: STDERR: # Fatal error in: ../../third_party/webrtc/pc/peer_connection.cc, line 575 STDERR: # last system error: 0 STDERR: # Check failed: (signaling_thread())->IsCurrent() STDERR: # Received signal 6 STDERR: #0 0x7f81d39e3de9 base::debug::CollectStackTrace() STDERR: #1 0x7f81d38f9ca3 base::debug::StackTrace::StackTrace() STDERR: #2 0x7f81d39e393b base::debug::(anonymous namespace)::StackDumpSignalHandler() STDERR: #3 0x7f81c9054140 (/lib/x86_64-linux-gnu/libpthread-2.31.so+0x1413f) STDERR: #4 0x7f81c8d72db1 gsignal STDERR: #5 0x7f81c8d5c537 abort STDERR: #6 0x7f81c7344032 rtc::webrtc_checks_impl::FatalLog() STDERR: #7 0x7f81c722e5c0 webrtc::webrtc_function_impl::CallHelpers<>::CallInlineStorage<>() STDERR: #8 0x7f81c7348d99 webrtc::robo_caller_impl::RoboCallerReceivers::Foreach() STDERR: #9 0x7f81c72d6e8e webrtc::webrtc_function_impl::CallHelpers<>::CallInlineStorage<>() STDERR: #10 0x7f81c7348d99 webrtc::robo_caller_impl::RoboCallerReceivers::Foreach() STDERR: #11 0x7f81c71c6df3 webrtc::webrtc_function_impl::CallHelpers<>::CallInlineStorage<>() STDERR: #12 0x7f81c7348d99 webrtc::robo_caller_impl::RoboCallerReceivers::Foreach() STDERR: #13 0x7f81c73135bc rtc::OpenSSLStreamAdapter::ContinueSSL() STDERR: #14 0x7f81c7312fd4 rtc::OpenSSLStreamAdapter::OnEvent() STDERR: #15 0x7f81c71c30d9 cricket::StreamInterfaceChannel::OnPacketReceived() STDERR: #16 0x7f81c71c640a cricket::DtlsTransport::OnReadPacket() STDERR: #17 0x7f81c71cad61 cricket::P2PTransportChannel::OnReadPacket() STDERR: #18 0x7f81c71bc90f cricket::Connection::OnReadPacket() STDERR: #19 0x7f81c71e6255 cricket::UDPPort::HandleIncomingPacket() STDERR: #20 0x7f81cd1f1bff blink::(anonymous namespace)::IpcPacketSocket::OnDataReceived() STDERR: #21 0x7f81cd1f645d blink::P2PSocketClientImpl::DataReceived() STDERR: #22 0x7f81cd50a16b network::mojom::blink::P2PSocketClientStubDispatch::Accept() STDERR: #23 0x7f81d2b4f642 mojo::InterfaceEndpointClient::HandleValidatedMessage() STDERR: #24 0x7f81d2b5304b mojo::MessageDispatcher::Accept() STDERR: #25 0x7f81d2b50bb1 mojo::InterfaceEndpointClient::HandleIncomingMessage() STDERR: #26 0x7f81d2b58a3a mojo::internal::MultiplexRouter::ProcessIncomingMessage() STDERR: #27 0x7f81d2b57f7f mojo::internal::MultiplexRouter::Accept() STDERR: #28 0x7f81d2b5304b mojo::MessageDispatcher::Accept() STDERR: #29 0x7f81d2b48851 mojo::Connector::DispatchMessage() STDERR: #30 0x7f81d2b492e7 mojo::Connector::ReadAllAvailableMessages() STDERR: #31 0x7f81d2b490a3 mojo::Connector::OnHandleReadyInternal() STDERR: #32 0x7f81d2b498f0 mojo::SimpleWatcher::DiscardReadyState() STDERR: #33 0x7f81d2d0e67a mojo::SimpleWatcher::OnHandleReady() STDERR: #34 0x7f81d2d0eb2b base::internal::Invoker<>::RunOnce() STDERR: #35 0x7f81d397f85b base::TaskAnnotator::RunTask() STDERR: #36 0x7f81d399a04c base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() STDERR: #37 0x7f81d3999c78 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() STDERR: #38 0x7f81d391fe64 base::MessagePumpDefault::Run() STDERR: #39 0x7f81d399a8dc base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() STDERR: #40 0x7f81d395ae55 base::RunLoop::Run() STDERR: #41 0x7f81d39c87f2 base::Thread::Run() Original change's description: > Reland "Replace sigslot usages with robocaller library." > > This is a reland of 40261c3 > > Note: Instead of changing the type of JsepTransportController->SignalSSLHandshakeError > added a new member with a different name and used it in webrtc code. > After this change do two more follow up CLs to completely remove the old code > from google3. > > Original change's description: > > Replace sigslot usages with robocaller library. > > > > - Replace all the top level signals from jsep_transport_controller. > > - There are still sigslot usages in this file so keep the inheritance > > and that is the reason for not having a binary size gain in this CL. > > > > Bug: webrtc:11943 > > Change-Id: I249d3b9710783aef70ba273e082ceeafe3056898 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185540 > > Commit-Queue: Lahiru Ginnaliya Gamathige <[email protected]> > > Reviewed-by: Mirko Bonadei <[email protected]> > > Reviewed-by: Karl Wiberg <[email protected]> > > Cr-Commit-Position: refs/heads/master@{#32321} > > Bug: webrtc:11943 > Change-Id: Ia07394ee395f94836f6b576c3a97d119a7678e1a > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/186946 > Commit-Queue: Lahiru Ginnaliya Gamathige <[email protected]> > Reviewed-by: Karl Wiberg <[email protected]> > Cr-Commit-Position: refs/heads/master@{#32359} [email protected],[email protected],[email protected] Change-Id: I6bce1775d10758ac4a9d05b855f473dd70bd9815 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:11943 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/187487 Reviewed-by: Guido Urdaneta <[email protected]> Commit-Queue: Guido Urdaneta <[email protected]> Cr-Commit-Position: refs/heads/master@{#32372}
JamesTerm
pushed a commit
to JamesTerm/owt-deps-webrtc
that referenced
this pull request
Apr 15, 2021
Assume that stream has single temporal layer if number of frames in GOF is set to zero (valid case). (cherry picked from commit 2f864fb) [email protected] Bug: chromium:879584 Change-Id: I7ced082190e40c1bf4cc1468babfd98b0a61f0dd Reviewed-on: https://webrtc-review.googlesource.com/98800 Reviewed-by: Philip Eliasson <[email protected]> Commit-Queue: Sergey Silkin <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#24622} Reviewed-on: https://webrtc-review.googlesource.com/98861 Reviewed-by: Sergey Silkin <[email protected]> Cr-Commit-Position: refs/branch-heads/70@{open-webrtc-toolkit#4} Cr-Branched-From: f18b352-refs/heads/master@{#24472}
rejohn
pushed a commit
to rejohn/owt-deps-webrtc
that referenced
this pull request
May 19, 2023
…/4 This CL forwards BlockingCall client locations to BlockingCallImpl. Fixed: chromium:1416199 Change-Id: Ic5865280ec5c72a09a64419940b8343e8a54986b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/295624 Commit-Queue: Markus Handell <[email protected]> Reviewed-by: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#39442}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create branch for 59-server