feat: Migrated :core:datastore module to KMP
#2737
Conversation
core/datastore/src/commonMain/kotlin/org/mifos/mobile/core/datastore/PreferencesHelper.kt
Outdated
Show resolved
Hide resolved
core/datastore/src/commonMain/kotlin/org/mifos/mobile/core/datastore/model/AppSettings.kt
Outdated
Show resolved
Hide resolved
core/datastore/src/commonMain/kotlin/org/mifos/mobile/core/datastore/model/User.kt
Outdated
Show resolved
Hide resolved
core/datastore/src/commonMain/kotlin/org/mifos/mobile/core/datastore/PreferencesHelper.kt
Outdated
Show resolved
Hide resolved
core/datastore/src/commonMain/kotlin/org/mifos/mobile/core/datastore/model/UserData.kt
Show resolved
Hide resolved
|
@niyajali done the changes |
niyajali
changed the title
:core:datastore module to KMP
core/datastore/src/commonMain/kotlin/org/mifos/mobile/core/datastore/model/AppSettings.kt
Outdated
Show resolved
Hide resolved
core/datastore/src/commonMain/kotlin/org/mifos/mobile/core/datastore/PreferencesHelper.kt
Outdated
Show resolved
Hide resolved
|
@niyajali done the changes you told brother, same like mobile-wallet |
@niyajali, this https://demo.mifos.community/ will not work, right? Is he supposed to change it, or should he keep it as is for now? |
core/datastore/src/commonMain/kotlin/org/mifos/mobile/core/datastore/PreferenceHelper.kt
Outdated
Show resolved
Hide resolved
core/datastore/src/commonMain/kotlin/org/mifos/mobile/core/datastore/DataState.kt
Outdated
Show resolved
Hide resolved
...datastore/src/commonMain/kotlin/org/mifos/mobile/core/datastore/UserPreferencesRepository.kt
Show resolved
Hide resolved
@revanthkumarJ @Nagarjuna0033 Are we using this endpoint anywhere in this module |
|
@revanthkumarJ Let's fix above mentioned changes by today so we can merge other PRs |
Yes we are using in this module
https://github.com/openMF/mifos-mobile/pull/2737/files#diff-b0e0f62dd255389c6d66dabf41f44d206ceba34294baa0fdc9359cd135a51e01 core/datastore/src/commonMain/kotlin/org/mifos/mobile/core/datastore/model/AppSettings.kt here @niyajali @Nagarjuna0033 this endpoint is currently working right |
|
@Nagarjuna0033 Above link isn't working |
|
@niyajali Done the changes . Please have a look at it once |
Fixes - Jira-108
Didn't create a Jira ticket, click here to create new.
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.