feat: Migrated :core:common module to KMP
#2743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biplab1
changed the title
niyajali
requested changes
Jan 14, 2025
.../common/src/commonMain/kotlin/org/mifos/mobile/core/common/ParcelableAndSerializableUtils.kt
Outdated
Show resolved
Hide resolved
core/common/src/commonMain/kotlin/org/mifos/mobile/core/common/CurrencyUtil.kt
Outdated
Show resolved
Hide resolved
core/common/src/commonMain/kotlin/org/mifos/mobile/core/common/LanguageHelper.kt
Show resolved
Hide resolved
core/common/src/commonMain/kotlin/org/mifos/mobile/core/common/Utils.kt
Outdated
Show resolved
Hide resolved
|
@biplab1 I think you can find the CurrencyHelper class in wallet project and for language helper you've create actual/expect object for now provide android specific functionality in this PR, and let's merge it because we need some other classes in other modules which is required and Language Helper is required but currently not so you can take your time and provide remaining platform implementation. and remove other functions and classes as mentioned in above comments. |
niyajali
changed the title
:core:common module to KMP
niyajali
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - Jira-#103
Didn't create a Jira ticket, click here to create new.
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.