Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Migrate :core:designsystem to KMP #2746

Merged
merged 10 commits into from
Jan 17, 2025

Conversation

biplab1
Copy link

@biplab1 biplab1 commented Jan 16, 2025

Fixes - Jira-#114

Didn't create a Jira ticket, click here to create new.

Please Add Screenshots If there are any UI changes.

Before After

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the static analysis check ./gradlew check or ci-prepush.sh to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@niyajali
Copy link
Collaborator

@biplab1 I've made all the necessary changes please take a look and add Jira link in this PR description, and let me know we'll merge this PR

@niyajali
Copy link
Collaborator

niyajali commented Jan 17, 2025

And configure GPG key for verified commits like mine, for more information search on google or checkout this link

Copy link
Collaborator

@niyajali niyajali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, could be merged soon

@niyajali niyajali marked this pull request as ready for review January 17, 2025 10:38
@biplab1
Copy link
Author

biplab1 commented Jan 17, 2025

And configure GPG key for verified commits like mine, for more information search on google or checkout this link

Okay, @niyajali I will check it out.

@biplab1
Copy link
Author

biplab1 commented Jan 17, 2025

@biplab1 I've made all the necessary changes please take a look and add Jira link in this PR description, and let me know we'll merge this PR

Added Jira ticket number.

@niyajali niyajali merged commit e54baf1 into openMF:kmp-impl Jan 17, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants