Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent app crash when clicking Mifos Initiative License and Change icon colors #2748

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

HekmatullahAmin
Copy link
Contributor

@HekmatullahAmin HekmatullahAmin commented Jan 16, 2025

  • Fixed the app crash issue when clicking the Mifos Initiative License.
  • In the "About Us" screen, fixed the inconsistency of icon colors (website, source code) that were different from the other icons.

Fixes - Jira-MM-88

Didn't create a Jira ticket, click here to create new.

Please Add Screenshots If there are any UI changes.

Before After
Screenshot 2025-01-16 at 12 08 02

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the static analysis check ./gradlew check or ci-prepush.sh to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

…nge icon colors

- Fixed the app crash issue when clicking the Mifos Initiative License.
- In the "About Us" screen, fixed the inconsistency of icon colors (website, source code) that were different from the other icons.
@niyajali
Copy link
Collaborator

@HekmatullahAmin create a Jira ticket and mention in description

@niyajali
Copy link
Collaborator

niyajali commented Jan 16, 2025

@HekmatullahAmin I'm saying to add a jira link in this PR description, so it will automatically link in Jira ticket.

@HekmatullahAmin
Copy link
Contributor Author

@HekmatullahAmin I'm saying to add a jira link in this PR description, so it will automatically link in Jira ticket.

done

@niyajali niyajali added the firebase-test-on Upload Application on Firebase For Testing label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
firebase-test-on Upload Application on Firebase For Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants