New UI to change password #1781
Conversation
| label = { Text(label) }, | ||
| label = { Text( | ||
| label, | ||
| color = NewUi.primaryColor, |
There was a problem hiding this comment.
Can you format these lines of code.
| ) { | ||
|
|
There was a problem hiding this comment.
Can you remove blank lines
| focusedBorderColor = Color.Transparent, // Cor da borda quando focado | ||
| unfocusedBorderColor = Color.Transparent, // Cor da borda quando não focado | ||
| errorBorderColor = Color.Transparent, // Cor da borda quando em erro | ||
| disabledBorderColor = Color.Transparent, // Cor da borda quando desabilitado |
There was a problem hiding this comment.
And remove these comments too
| modifier = Modifier.background(color = Color.White), | ||
|
|
There was a problem hiding this comment.
Remove these extra blank lines..
| ) | ||
| .fillMaxWidth(0.9f) | ||
| .padding(vertical = 8.dp), | ||
|
|
| ) | ||
| Spacer(modifier = Modifier.height(8.dp)) | ||
|
|
||
|
|
|
Run |
|
Can you upload both Old UI and Updated UI Image |
|
Commit your changes, i didn't see any |
git
Outdated
|
@rodrigosouzalopes94 fix this build error
|
There was a problem hiding this comment.
Hello @rodrigosouzalopes94 , thanks for the PR but You modified the old OutlinedTextField and set colors to color.Transparent. We won't be using that anymore.
Take reference from finance/payment/editProfile screen. also after you are done please attach the figma UI as well
Can you help to make the clean code about these styles? |
it's not about styles, You need to modify |
|
Done. |
|
Some fixed blank spaces and remove comments Delete git file Fixed the password screen
rodrigosouzalopes94
force-pushed
the
change-passowrd-ui
branch
from
121882e to
08cc8ed
Compare
|
Figma UI |
|
@rodrigosouzalopes94 As I can see, the trailing icon color doesn't match the color as per Figma UI |
|
I gonna fixed. |
|
@rodrigosouzalopes94 take a look into this pr #1787 , might helps |
|
@niyajali can you help @rodrigosouzalopes94 so we can merge this PR |
|
@rodrigosouzalopes94 Here is the pr #1787 of this module |
Issue Fix
Fixes #{Issue Number}
Jira Task: [MW145]https://mifosforge.jira.com/browse/MW-148
Screenshots
Description
A new change password screen
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.