Change clone() -> to_heap() for new CHECK_FILE task

openPMD · Oct 12, 2022 · 829eb3e · 829eb3e
1 parent cf428f0
commit 829eb3e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/include/openPMD/IO/IOTask.hpp b/include/openPMD/IO/IOTask.hpp
@@ -133,14 +133,15 @@ struct OPENPMDAPI_EXPORT Parameter<Operation::CHECK_FILE>
     : public AbstractParameter
 {
     Parameter() = default;
-    Parameter(Parameter const &p)
-        : AbstractParameter(), name(p.name), fileExists(p.fileExists)
-    {}
+    Parameter(Parameter &&) = default;
+    Parameter(Parameter const &p) = default;
+    Parameter &operator=(Parameter &&) = default;
+    Parameter &operator=(Parameter const &) = default;
 
-    std::unique_ptr<AbstractParameter> clone() const override
+    std::unique_ptr<AbstractParameter> to_heap() && override
     {
         return std::unique_ptr<AbstractParameter>(
-            new Parameter<Operation::CHECK_FILE>(*this));
+            new Parameter<Operation::CHECK_FILE>(std::move(*this)));
     }
 
     std::string name = "";

diff --git a/test/ParallelIOTest.cpp b/test/ParallelIOTest.cpp
@@ -47,7 +47,8 @@ std::vector<std::string> testedFileExtensions()
         allExtensions.begin(), allExtensions.end(), [](std::string const &ext) {
             // sst and ssc need a receiver for testing
             // bp4 is already tested via bp
-            return ext == "sst" || ext == "ssc" || ext == "bp4" | ext == "json";
+            return ext == "sst" || ext == "ssc" || ext == "bp4" ||
+                ext == "toml" || ext == "json";
         });
     return {allExtensions.begin(), newEnd};
 }