Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Travis: OSX #101

Closed
wants to merge 1 commit into from
Closed

[WIP] Travis: OSX #101

wants to merge 1 commit into from

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Mar 12, 2018

Try to add OSX testing (no-MPI): #86

To Do

Boost RT bug:

  • Probably a Boost.Test bug:
unknown location:0: fatal error: in "Test setup": boost::runtime::access_to_missing_argument: There is no argument provided for parameter color_output

Tried to debug with debug flags in boost but hard to grasp. Tried to run through with lldb but looks like the check (breakpoint set --file /Users/Axel/lib/boost-1.66.0/include/boost/test/utils/runtime/argument.hpp --line 97) is somehow triggert with a different param... as if something is writing in the stack... Valgrind is complaining about an invalid free from it. clang address sanitizier as well. Seen up to Boost 1.66.0. Also reproducible (besides travis' AppleClang 8) with AppleClang 7.0 on an older local mac.

See also: kaitai-io/kaitai_struct_cpp_stl_runtime#10 (comment)

Maybe we just move to Catch2 asap and get rid of it.

ld: warning: direct access in function 'pybind11::detail::erase_all(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)' from file 'CMakeFiles/openPMD.py.dir/src/binding/python/openPMD.cpp.o' to global weak symbol 'std::__1::char_traits<char>::eq(char, char)' from file 'lib/libopenPMD.a(Series.cpp.o)' means the weak symbol cannot be overridden at runtime. This was likely caused by different translation units being compiled with different visibility settings

@ax3l ax3l added tests third party third party libraries that are shipped and/or linked labels Mar 12, 2018
@ax3l ax3l force-pushed the topic-travisOSX branch 26 times, most recently from 5bf51d5 to ed520a8 Compare March 12, 2018 14:41
@ax3l ax3l force-pushed the topic-travisOSX branch 12 times, most recently from ae3d6c8 to b5cf518 Compare March 14, 2018 14:12
CMakeLists.txt Outdated
@@ -366,6 +366,9 @@ foreach(testname ${openPMD_TEST_NAMES})
if(TARGET Boost::unit_test_framework)
target_link_libraries(${testname}Tests PRIVATE Boost::unit_test_framework)
endif()
if(APPLE)
target_compile_definitions(${testname}Tests PRIVATE "-DBOOST_TEST_DYN_LINK")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wild guess, did not work.
remove

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, or, target_compile_definitions(${testname}Tests PRIVATE $<$<CXX_COMPILER_ID:AppleClang>:BOOST_TEST_DYN_LINK>)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, yes that's more compact via a generator expression.
We migrated to Catch2 for testing now #110, and added OSX CI in #115 .

@ax3l ax3l force-pushed the topic-travisOSX branch from b5cf518 to 1c7314c Compare March 14, 2018 15:19
Try to add OSX testing (no-MPI).
@ax3l ax3l force-pushed the topic-travisOSX branch from 1c7314c to d23f6f7 Compare March 14, 2018 15:20
@ax3l ax3l added the machine/system machine & HPC system specific issues label Mar 24, 2018
@ax3l
Copy link
Member Author

ax3l commented Apr 4, 2018

I will keep this open for reference and open a new OSX PR after we switched from Boost.Test to Catch2 #110

Sorry Boost.Test, I gave you my precious night-time to fix you and could not succeed. RIP :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
machine/system machine & HPC system specific issues tests third party third party libraries that are shipped and/or linked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants