-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Travis: OSX #101
[WIP] Travis: OSX #101
Conversation
5bf51d5
to
ed520a8
Compare
ae3d6c8
to
b5cf518
Compare
CMakeLists.txt
Outdated
@@ -366,6 +366,9 @@ foreach(testname ${openPMD_TEST_NAMES}) | |||
if(TARGET Boost::unit_test_framework) | |||
target_link_libraries(${testname}Tests PRIVATE Boost::unit_test_framework) | |||
endif() | |||
if(APPLE) | |||
target_compile_definitions(${testname}Tests PRIVATE "-DBOOST_TEST_DYN_LINK") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wild guess, did not work.
remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, or, target_compile_definitions(${testname}Tests PRIVATE $<$<CXX_COMPILER_ID:AppleClang>:BOOST_TEST_DYN_LINK>)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to add OSX testing (no-MPI).
I will keep this open for reference and open a new OSX PR after we switched from Boost.Test to Catch2 #110 Sorry Boost.Test, I gave you my precious night-time to fix you and could not succeed. RIP :-) |
Try to add OSX testing (no-MPI): #86
To Do
Boost RT bug:
Tried to debug with debug flags in boost but hard to grasp. Tried to run through with
lldb
but looks like the check (breakpoint set --file /Users/Axel/lib/boost-1.66.0/include/boost/test/utils/runtime/argument.hpp --line 97
) is somehow triggert with a different param... as if something is writing in the stack... Valgrind is complaining about an invalid free from it. clang address sanitizier as well. Seen up to Boost 1.66.0. Also reproducible (besides travis' AppleClang 8) with AppleClang 7.0 on an older local mac.See also: kaitai-io/kaitai_struct_cpp_stl_runtime#10 (comment)
Maybe we just move to Catch2 asap and get rid of it.
issue: